Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nullable attribute and validation #104

Closed
wants to merge 1 commit into from
Closed

Added nullable attribute and validation #104

wants to merge 1 commit into from

Conversation

Mallone63
Copy link

'Nullable' could be useful when 'required' is set to 'no'.

@AirisX
Copy link

AirisX commented Sep 21, 2017

Hi @gonditeniz ,
have you any plans on merging that?

@Grokzen
Copy link
Owner

Grokzen commented Dec 3, 2017

@mall The code you have submited is lacking some basic things. One is tests for the new attribute/feature. Next is example code for this feature. Third is general documentation changes for this. Fourth is updates in changelog file. Without fixing these basic things i will not merge this PR.

@Grokzen Grokzen closed this Dec 3, 2017
@Grokzen
Copy link
Owner

Grokzen commented Feb 6, 2018

@Mallone63 This MR needs some more work in order to be mergable. If possible please rebase your changes ontop of the latest master branch in my repo inside your fork, fix the comments that you have here above and finally submit a new MR and i will get this feature in to the code base. I will not do more work on this feature inside this MR scope until that is done. I like the feature and want it in but you have to complete it first.

@Mallone63
Copy link
Author

@Grokzen PR has been rebased on current master branch. Added tests, example \ docs, and changelog update.
#117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants