Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to regex rule #168

Closed
wants to merge 3 commits into from
Closed

Conversation

oliparcol
Copy link
Contributor

This pull request improves the way regex rules are handled by:

  • making sure they start and end with parentheses (fixed some tests along the way)
  • casting the keys to str before trying to match them against the regex. This unifies the way required parameter and key matching against the regex are handled.

I've also casted tmp_path fixture to str in 3b547fa to make the tests compatible with latest pytest version as it is now a pathlib (see https://docs.pytest.org/en/latest/tmpdir.html#the-tmp-path-fixture).

@Grokzen
Copy link
Owner

Grokzen commented Dec 30, 2020

@oliparcol I manually resolved the conflicts and merged this PR manually and pushed it to master branch. Consider this PR merged/fixed even if it says closed :) Thank you for this contribution.

@Grokzen Grokzen closed this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants