-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs #27
Improve docs #27
Conversation
LGTM :] If you want before i merge this, you can add yourself to I will probably not make a new release right away after merging this and wait for some code change from elsewhere before doing it. |
Okay, done. I made a new Documentation group and put you and me in it. :) |
Don't merge just yet. |
@scottclowe Ok, i will wait some, just ping when you feel it is ready to merge |
Sorry for the delay with the documentation. I did not have time to look at it for the last couple of weeks. I am looking at it now and I was trying to understand what This succeeds:
This breaks due to unspecified type in the subrule:
Can you explain what it is supposed to do? |
Ping @Grokzen |
@@ -1,17 +1,15 @@ | |||
# Implemented validation rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scottclowe What is the main reason to change from the markdown way of creating headings to use the rst way of creating headings? Also that you have mixed heading types inside the document, both md and rst O.o
I would prefer to stick with markdown as it works the best on github. Or do you have some other reason in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The underline styles are all Markdown, not mixed.
They do not mention it in the GitHub Markdown Basics, but they do in the
official Markdown docs basics and detailed, and in this handy GitHub-centric cheat sheet.
You can see it renders correctly here.
If you prefer the atx-style headings with all #
, I can swap them to that. The motivation was it made it a lot easier for me to tell the depth of the content when editing the unparsed .md file. I find the difference between -----------------
and ###
is much more striking between ##
and ###
. But I am happy to change them back for internal consistency if you prefer that.
Good links there. I allways assumed that the atx-style was the only one that was valid in markdown and that the I do would like to change back to atx-style because of a few reasons. I saw that it renders properly and that is not really the problem. The main thing i like is the consistency across all MD files in the docs to use the same syntax. If that syntax would be MD or RST is not a big issue as long as there is some chosen standard. However, one thing worth mention is that i have had plans on moving all this docs to a proper readthedocs page and i do think that those pages is done with RST so the pages will be rewritten to RST in the future anyway :] If you change the heading i will merge it after that as it LGTM :] |
The example given is an incomplete copy of a test case tests/files/success/16s.yaml but because the schema is incomplete and the data section is complete, this breaks the test case. Consequently the example code did not work. I have fixed this by removing the leftover entry in Data so the example Data is compliant with the existing Schema.
The example for regex key name matching is now more concise to make the example clearer.
Only in the first few sections of text.
Move timestamps so it is a subsection of Types Move all the seq and map only constraints so they are grouped together at the bottom of the constraints section.
For consistency with matching-rule.
This will make it easier for new users to understand that the schema does not need to go in the same file as the data, but goes in a different file.
Previously had a schema section and no data.
Listed @Grokzen and @scottclowe in the Documentation section.
It doesn't make sense to introduce matching-rule before regex.
Now `True` and `False` everytime.
The "Important notes on version schema changes" section in `README.md` was referenced in `ReleaseNotes.rst`, but has since been removed from `README.md`. I have added the text back in the place where the reference was, for posterity.
- Make two map type definiton styles clearer - Mention map specific constraints in the description of map type - Emphasise that map keys are assumed to be optional and not required, as might be assumed.
Make the constraint (vs rule) terminology match the original kwalify.
- Add an example - Improve description
and not have a colon after them either, since they are headings.
Fixed the headings so they are all |
Many thanks for this great work @scottclowe :] |
I was trying and failing to get a
regex;(regex-pattern)
mapping key to work in my schema, so I had a look at the documentation and tried theregex;(regex-pattern)
example on its own, and that didn't work either. So I decided to fix the documentation to have a working example here.When doing this I got a little carried away and started making other improvements to the documentation, including some spelling and grammar corrections, and changes to the ordering of sections in the Validation Rules file.
Hope this is all okay!