Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where regexes are matched as strings when 'required' #86

Merged
merged 1 commit into from
Jan 6, 2017

Conversation

cogwirrel
Copy link

When a regex in a mapping is required, it would get matched as a string rather than a regex.

This pull request fixes that issue.

See the success test for the case that would previously fail.

@coveralls
Copy link

coveralls commented Jan 6, 2017

Coverage Status

Coverage increased (+0.1%) to 87.652% when pulling 459204f on cogwirrel:unstable into 2c8e3c0 on Grokzen:unstable.

@Grokzen
Copy link
Owner

Grokzen commented Jan 6, 2017

@cogwirrel Nice find, good test cases and good implementation. The only thing i am missing for this one is a line in docs/release-notes.rst and if you want, add yourself to docs/authors.rst and this should be mergable.

@cogwirrel
Copy link
Author

@Grokzen Thanks! Updated those files.

@coveralls
Copy link

coveralls commented Jan 6, 2017

Coverage Status

Coverage increased (+0.1%) to 87.652% when pulling 068183d on cogwirrel:unstable into 2c8e3c0 on Grokzen:unstable.

@Grokzen
Copy link
Owner

Grokzen commented Jan 6, 2017

@cogwirrel Awesome. Thanks for the fix.

@Grokzen Grokzen merged commit a4924b0 into Grokzen:unstable Jan 6, 2017
@Grokzen Grokzen added the Merged label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants