dramatically improve uibarbuttonitem appearance customization

Grouper · May 24, 2013 · d797840 · d797840
1 parent 7fbd17a
commit d797840
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 56 deletions.
diff --git a/Classes/ios/UIBarButtonItem+FlatUI.h b/Classes/ios/UIBarButtonItem+FlatUI.h
@@ -10,15 +10,24 @@
 
 @interface UIBarButtonItem (FlatUI)
 
+// styles a single bar button item
+- (void) configureFlatButtonWithColor:(UIColor *)color
+                     highlightedColor:(UIColor *)highlightedColor
+                         cornerRadius:(CGFloat) cornerRadius UI_APPEARANCE_SELECTOR;
+
+// styles all bar button items that exist within a class heirarchy (same as UIAppearanceProxy methods)
 + (void) configureFlatButtonsWithColor:(UIColor *) color
                       highlightedColor:(UIColor *)highlightedColor
-                          cornerRadius:(CGFloat) cornerRadius;
+                          cornerRadius:(CGFloat) cornerRadius
+                       whenContainedIn:(Class <UIAppearanceContainer>)containerClass, ... NS_REQUIRES_NIL_TERMINATION;
 
+// styles all bar button items (can be overwritten with the above methods)
 + (void) configureFlatButtonsWithColor:(UIColor *) color
                       highlightedColor:(UIColor *)highlightedColor
-                          cornerRadius:(CGFloat) cornerRadius
-                       whenContainedIn:(Class <UIAppearanceContainer>)ContainerClass;
+                          cornerRadius:(CGFloat) cornerRadius;
+
 
+// removes the text shadows off a single bar button item (sadly, this can't be easily done for all buttons simultaneously)
 - (void) removeTitleShadow;
 
 @end
diff --git a/Classes/ios/UIBarButtonItem+FlatUI.m b/Classes/ios/UIBarButtonItem+FlatUI.m
@@ -11,54 +11,46 @@
 
 @implementation UIBarButtonItem (FlatUI)
 
+- (void) configureFlatButtonWithColor:(UIColor *)color
+                     highlightedColor:(UIColor *)highlightedColor
+                         cornerRadius:(CGFloat) cornerRadius {
+
+    [UIBarButtonItem configureItemOrProxy:self forFlatButtonWithColor:color highlightedColor:color cornerRadius:cornerRadius];
+
+}
+
 + (void) configureFlatButtonsWithColor:(UIColor *) color
                       highlightedColor:(UIColor *)highlightedColor
                           cornerRadius:(CGFloat) cornerRadius {
 
-    UIImage *backButtonPortraitImage = [UIImage backButtonImageWithColor:color
-                                                              barMetrics:UIBarMetricsDefault
-                                                            cornerRadius:cornerRadius];
-    UIImage *highlightedBackButtonPortraitImage = [UIImage backButtonImageWithColor:highlightedColor
-                                                                         barMetrics:UIBarMetricsDefault
-                                                                       cornerRadius:cornerRadius];
-    UIImage *backButtonLandscapeImage = [UIImage backButtonImageWithColor:color
-                                                               barMetrics:UIBarMetricsLandscapePhone
-                                                             cornerRadius:2];
-    UIImage *highlightedBackButtonLandscapeImage = [UIImage backButtonImageWithColor:highlightedColor
-                                                                          barMetrics:UIBarMetricsLandscapePhone
-                                                                        cornerRadius:2];
-
-    id appearance = [UIBarButtonItem appearanceWhenContainedIn:[UINavigationBar class], [UINavigationController class], nil];
-
-    [appearance setBackButtonBackgroundImage:backButtonPortraitImage
-                                    forState:UIControlStateNormal
-                                  barMetrics:UIBarMetricsDefault];
-    [appearance setBackButtonBackgroundImage:backButtonLandscapeImage
-                                    forState:UIControlStateNormal
-                                  barMetrics:UIBarMetricsLandscapePhone];
-    [appearance setBackButtonBackgroundImage:highlightedBackButtonPortraitImage
-                                    forState:UIControlStateHighlighted
-                                  barMetrics:UIBarMetricsDefault];
-    [appearance setBackButtonBackgroundImage:highlightedBackButtonLandscapeImage
-                                    forState:UIControlStateHighlighted
-                                  barMetrics:UIBarMetricsLandscapePhone];
-
-    [appearance setBackButtonTitlePositionAdjustment:UIOffsetMake(1.0f, 1.0f) forBarMetrics:UIBarMetricsDefault];
-    [appearance setBackButtonTitlePositionAdjustment:UIOffsetMake(1.0f, 1.0f) forBarMetrics:UIBarMetricsLandscapePhone];
-
-    UIImage *buttonImage = [UIImage imageWithColor:color cornerRadius:cornerRadius];
-    [appearance setBackgroundImage:buttonImage forState:UIControlStateNormal barMetrics:UIBarMetricsDefault];
-
-    id toolbarAppearance = [UIBarButtonItem appearanceWhenContainedIn:[UIToolbar class], nil];
-    [toolbarAppearance setBackgroundImage:[UIImage buttonImageWithColor:color cornerRadius:cornerRadius shadowColor:color shadowInsets:UIEdgeInsetsZero] forState:UIControlStateNormal barMetrics:UIBarMetricsDefault];
+    [self configureFlatButtonsWithColor:color highlightedColor:highlightedColor cornerRadius:cornerRadius whenContainedIn:[UINavigationBar class], [UINavigationController class], nil];
 }
 
 + (void) configureFlatButtonsWithColor:(UIColor *) color
                       highlightedColor:(UIColor *)highlightedColor
                           cornerRadius:(CGFloat) cornerRadius
-                       whenContainedIn:(Class <UIAppearanceContainer>)ContainerClass
-{
-
+                       whenContainedIn:(Class <UIAppearanceContainer>)containerClass, ... {
+    va_list vl;
+    va_start(vl, containerClass);
+    id appearance = [UIBarButtonItem appearanceWhenContainedIn:containerClass, nil];
+    va_end(vl);
+    [UIBarButtonItem configureItemOrProxy:appearance forFlatButtonWithColor:color highlightedColor:color cornerRadius:cornerRadius];
+}
+
+- (void) removeTitleShadow {
+    NSMutableDictionary *titleTextAttributes = [[self titleTextAttributesForState:UIControlStateNormal] mutableCopy];
+    if (!titleTextAttributes) {
+        titleTextAttributes = [NSMutableDictionary dictionary];
+    }
+    [titleTextAttributes setValue:[NSValue valueWithUIOffset:UIOffsetMake(0, 0)] forKey:UITextAttributeTextShadowOffset];
+    [self setTitleTextAttributes:titleTextAttributes forState:UIControlStateNormal];
+}
+
+//helper method, basically a wrapper to allow creating a custom UIAppearance method that doesn't conform to the usual naming style
++ (void) configureItemOrProxy:(id)appearance
+       forFlatButtonWithColor:(UIColor *)color
+             highlightedColor:(UIColor *)highlightedColor
+                 cornerRadius:(CGFloat) cornerRadius {
     UIImage *backButtonPortraitImage = [UIImage backButtonImageWithColor:color
                                                               barMetrics:UIBarMetricsDefault
                                                             cornerRadius:cornerRadius];
@@ -72,8 +64,6 @@ + (void) configureFlatButtonsWithColor:(UIColor *) color
                                                                           barMetrics:UIBarMetricsLandscapePhone
                                                                         cornerRadius:2];
 
-    id appearance = [UIBarButtonItem appearanceWhenContainedIn:ContainerClass, nil];
-
     [appearance setBackButtonBackgroundImage:backButtonPortraitImage
                                     forState:UIControlStateNormal
                                   barMetrics:UIBarMetricsDefault];
@@ -93,18 +83,7 @@ + (void) configureFlatButtonsWithColor:(UIColor *) color
     UIImage *buttonImage = [UIImage imageWithColor:color cornerRadius:cornerRadius];
     [appearance setBackgroundImage:buttonImage forState:UIControlStateNormal barMetrics:UIBarMetricsDefault];
 
-    id toolbarAppearance = [UIBarButtonItem appearanceWhenContainedIn:ContainerClass, nil];
-    [toolbarAppearance setBackgroundImage:[UIImage buttonImageWithColor:color cornerRadius:cornerRadius shadowColor:color shadowInsets:UIEdgeInsetsZero] forState:UIControlStateNormal barMetrics:UIBarMetricsDefault];
-
 }
 
-- (void) removeTitleShadow {
-    NSMutableDictionary *titleTextAttributes = [[self titleTextAttributesForState:UIControlStateNormal] mutableCopy];
-    if (!titleTextAttributes) {
-        titleTextAttributes = [NSMutableDictionary dictionary];
-    }
-    [titleTextAttributes setValue:[NSValue valueWithUIOffset:UIOffsetMake(0, 0)] forKey:UITextAttributeTextShadowOffset];
-    [self setTitleTextAttributes:titleTextAttributes forState:UIControlStateNormal];
-}
 
 @end
diff --git a/Example/FlatUIKitExample/ViewController.m b/Example/FlatUIKitExample/ViewController.m
@@ -40,14 +40,27 @@ - (void)viewDidLoad
     [super viewDidLoad];
     self.title = @"Flat UI";
     self.view.backgroundColor = [UIColor cloudsColor];
-    [UIBarButtonItem configureFlatButtonsWithColor:[UIColor peterRiverColor] highlightedColor:[UIColor belizeHoleColor] cornerRadius:3];
+    [UIBarButtonItem configureFlatButtonsWithColor:[UIColor peterRiverColor]
+                                  highlightedColor:[UIColor belizeHoleColor]
+                                      cornerRadius:3
+                                   whenContainedIn:[UINavigationBar class], nil];
 
     self.navigationItem.rightBarButtonItem = [[UIBarButtonItem alloc] initWithTitle:@"Button"
                                                                               style:UIBarButtonItemStylePlain
                                                                              target:nil
                                                                              action:nil];
     [self.navigationItem.rightBarButtonItem removeTitleShadow];
 
+    self.navigationItem.leftBarButtonItem = [[UIBarButtonItem alloc] initWithTitle:@"Button"
+                                                                              style:UIBarButtonItemStylePlain
+                                                                             target:nil
+                                                                             action:nil];
+    [self.navigationItem.rightBarButtonItem removeTitleShadow];
+
+    [self.navigationItem.leftBarButtonItem configureFlatButtonWithColor:[UIColor alizarinColor]
+                                                       highlightedColor:[UIColor pomegranateColor]
+                                                           cornerRadius:3];
+
     self.alertViewButton.buttonColor = [UIColor turquoiseColor];
     self.alertViewButton.shadowColor = [UIColor greenSeaColor];
     self.alertViewButton.shadowHeight = 3.0f;