Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bundler #3128

Closed
cesy opened this issue Nov 2, 2022 · 8 comments · Fixed by #3139
Closed

Upgrade bundler #3128

cesy opened this issue Nov 2, 2022 · 8 comments · Fixed by #3139

Comments

@cesy
Copy link
Member

cesy commented Nov 2, 2022

Deploy is now failing because apparently our Gemfile needs bundler 2 or later, and we're on 1.x. I don't currently have a working dev env, can someone do the honours of uplifting everything?

@cesy
Copy link
Member Author

cesy commented Nov 2, 2022

It looks like this is because of Heroku config - on staging we were still on heroku-18, and trying to upgrade to heroku-20, which also has old bundler. Upgrading to heroku-22 in progress to see if that helps.

@cesy
Copy link
Member Author

cesy commented Nov 2, 2022

Okay, apparently Heroku looks not just at the bundled-with, but also the other bits of the gemfile.lock, so we need to update those as well before it will deploy with the right bundler. https://devcenter.heroku.com/articles/ruby-support#libraries

@cesy cesy mentioned this issue Nov 2, 2022
@CloCkWeRX
Copy link
Collaborator

In heroku, I cancelled the upgrade to -22 for the moment. Will muck around with various deps shortly

@CloCkWeRX
Copy link
Collaborator

Hmm, looks like this was already fixed in dev.

@CloCkWeRX CloCkWeRX reopened this Nov 6, 2022
@CloCkWeRX
Copy link
Collaborator

-----> Building on the Heroku-22 stack
-----> Using buildpack: heroku/ruby
-----> Ruby app detected
-----> Installing bundler 1.17.3
-----> Removing BUNDLED WITH version in the Gemfile.lo

... facepalm WHY.

@CloCkWeRX
Copy link
Collaborator

@CloCkWeRX
Copy link
Collaborator

6e21cae + version-18 fixed the bundler problem.

@CloCkWeRX
Copy link
Collaborator

-----> Building on the Heroku-18 stack
-----> Using buildpack: heroku/ruby
-----> Ruby app detected
-----> Installing bundler 2.3.10
-----> Removing BUNDLED WITH version in the Gemfile.lock
-----> Compiling Ruby/Rails
###### WARNING:
       Your app was upgraded to bundler 2.3.10.
       Previously you had a successful deploy with bundler 1.17.3.
       
       If you see problems related to the bundler version please refer to:
       https://devcenter.heroku.com/articles/bundler-version#known-upgrade-issues
       
-----> Using Ruby version: ruby-3.0.4
       Ruby version change detected. Clearing bundler cache.
       Old: ruby 2.7.5p203 (2021-11-24 revision f69aeb8314) [x86_64-linux]
       New: ruby 3.0.4p208 (2022-04-12 revision 3fa771dded) [x86_64-linux]
-----> Installing dependencies using bundler 2.3.10
       Running: BUNDLE_WITHOUT='development:test' BUNDLE_PATH=vendor/bundle BUNDLE_BIN=vendor/bundle/bin BUNDLE_DEPLOYMENT=1 bundle install -j4
       Fetching gem metadata from https://rubygems.org/.......
       Fetching gem metadata from https://rails-assets.org/..
       Fetching https://github.com/restarone/comfortable-mexican-sofa.git
       Fetching rake 13.0.6
       Installing rake 13.0.6
       Fetching concurrent-ruby 1.1.10
       Fetching minitest 5.16.3
       Fetching zeitwerk 2.6.4
       Fetching builder 3.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants