Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to set up predictable median harvest time in specs #3624

Open
CloCkWeRX opened this issue Feb 4, 2024 · 0 comments
Open

Make it easier to set up predictable median harvest time in specs #3624

CloCkWeRX opened this issue Feb 4, 2024 · 0 comments

Comments

@CloCkWeRX
Copy link
Collaborator

For https://github.com/Growstuff/growstuff/pull/3623/files#diff-bb9fcf8d7443df378cf564c02a2ac5b12bf5b036a595fce0303a595060199656L17

I just went right to the DB and stuck in the medians, because I was caught off guard by the predictable_planting factory not actually being predictable for harvests.

https://github.com/Growstuff/growstuff/blob/dev/spec/features/plantings/prediction_spec.rb#L6 shows the full amount of data you have to set up, and it's ... a lot.

Either:

Make the factory/traits for a predictable planting also set up harvests or fake it similar to how I did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant