fix: add window check before addEventListener #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In scrollbar-width, the code was doing window.addEventListener even when window was undefined. This broke simplebar in SSR environments.
|
Looking at the codebase i believe this might not be the only issue in SSR environments. |
Closed
|
Amazing, thank you for your contribution!
I'm not sure what you are refering to but the lib is supporting SSR, this specific case is a regression due to a change in a recent PR. So this fix only should be fine I think. |
Grsmto
requested changes
Oct 21, 2019
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scrollbar-width.js, the code was doing window.addEventListener even when window was undefined.
This broke simplebar in SSR environments.
This commits adds a check before trying to add the resize event.