Added ability to scroll with keyboard

[Vikkivi]

It was impossible to scroll slider with keyboard in Chrome and Safari.
I added tabindex="0" to allow focusing on slider and aria-label for screen readers.
More info here https://marcus.io/blog/accessible-overflow

[Grsmto]

Great stuff! Thanks!

[oleg-slapdash]

@Grsmto this should be configurable since it breaks existing keyboard navigation in existing products. According to your previous comment:

I don't understand what you mean by "Keyboard operability is absent". It seems to work exactly the same way as a native overflow: auto. Just applying overflow: auto to a div won't give it a tabindex so SimpleBar doesn't neither.
It would be too arbitrary for SimpleBar to add tabindex by default as it's not there natively. So you would have to add it yourself manually in JS.

Which makes total sense. Is it possible to make it configurable?

[codeart1st]

I don't understand the need for setting the tabindex on the wrapper container. It might be needed for pure text content, but with an tabable item in it, it was completely fine before the change. Now it's an unnecessary extra tab. Also some extra css for the focus state is needed to keep up with existing UI.

The change might be fine if it's optional or can be disabled.

[paulkirow]

Hard coding role="region" is also quite opinionated. Prior to this update we used simplebar on our navigation element which had tabable items inside. In our context, for screen readers there is now an additional unnecessary declaration of "scrollable content - region".

I can remove the parent role in my page but I'm unable to update this role="region" to a more applicable role.

For now I'm just going to use a version prior to this change.

I agree with other comments, this feature should be configurable, ideally disabled by default.

[mcuppi]

For anyone who wants to disable this behavior, you can use the following pattern:

const simpleBar = new SimpleBarJS(scrollElement, options);
simpleBar.contentWrapperEl.removeAttribute("tabindex");

This isn't ideal, but it works until the feature is made configurable (if ever).

[kalnode]

Where did this end up?

@mcuppi 's workaround works for me, but is it still necessary?

[shubham-padia]

tabIndex is now configurable via #695

[tlthiem]

time for a release then

[shubham-padia]

Latest release already has this change.

[tlthiem]

nvm 3.2.6 got it