Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adiciona post com vídeos, slides e fotos do encontro de 22 de julho #31

Merged
merged 3 commits into from
Jul 31, 2017
Merged

Adiciona post com vídeos, slides e fotos do encontro de 22 de julho #31

merged 3 commits into from
Jul 31, 2017

Conversation

turicas
Copy link
Member

@turicas turicas commented Jul 31, 2017

No description provided.

@turicas
Remove plugin readtime
3ad95ef 
Esse plugin por algum motivo está gerando conflitos com o uso de
`{filename}` para linkar outros artigos.
@turicas
Adiciona post com links para vídeos, slides e fotos
5ea3fa6
@turicas
Atualiza post de chamada para encontro
8bc0545
ellisonleao
ellisonleao reviewed Jul 31, 2017
View reviewed changes
Copy link
Contributor

@ellisonleao ellisonleao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fiquei curioso pra saber mais desse problema

@turicas
Copy link
Member Author

turicas commented Jul 31, 2017

@ellisonleao por algum motivo ele não consegue encontrar quando uso {filename} e esse plugin está habilitado, mas não cheguei a procurar muito sobre (não tive tempo pra isso). Minha sugestão é o PR entrar assim mesmo e depois pararmos para tentar resolver o problema no plugin (já que não é algo necessário de funcionar no momento).

@ellisonleao
Copy link
Contributor

Ok, só lembra de abrir uma issue sobre isso, por favor. No mais, LGTM

@turicas turicas mentioned this pull request Jul 31, 2017
Open
@turicas
Copy link
Member Author

turicas commented Jul 31, 2017

@ellisonleao feito: #32. Obrigado!

@turicas turicas merged commit 08e35e6 into src Jul 31, 2017
@turicas turicas deleted the videos-encontro-22jul branch July 31, 2017 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellisonleao ellisonleao ellisonleao left review comments

@wiliamsouza wiliamsouza Awaiting requested review from wiliamsouza

@ramiroluz ramiroluz Awaiting requested review from ramiroluz

@marcelobelli marcelobelli Awaiting requested review from marcelobelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turicas @ellisonleao