Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Grease reference to 1.1.10 #29

Closed
jbrichau opened this issue Jul 11, 2014 · 5 comments
Closed

Upgrade Grease reference to 1.1.10 #29

jbrichau opened this issue Jul 11, 2014 · 5 comments
Milestone

Comments

@jbrichau
Copy link
Member

I noticed GLASS1 is still referencing Grease 1.0.7.x

Seems to me that an upgrade to 1.1.10 would be good to do. We need (and load) it in Seaside.

@dalehenrich
Copy link
Member

absolutely ... I can make that change when I move and rename the glass repo
... as long as that makes sense to you as well?

On Fri, Jul 11, 2014 at 8:56 AM, Johan Brichau notifications@github.com
wrote:

I noticed GLASS1 is still referencing Grease 1.0.7.x

Seems to me that an upgrade to 1.1.10 would be good to do. We need (and
load) it in Seaside.


Reply to this email directly or view it on GitHub
glassdb#29.

@jbrichau
Copy link
Member Author

Anytime when it's convenient for you will do actually. I posted the issue so it gets picked up, but it's not a showstopper anywhere (I assume)

@dalehenrich dalehenrich modified the milestone: 1.1.0 Nov 11, 2014
@jbrichau
Copy link
Member Author

Let's make that a reference to v1.1.x

@dalehenrich
Copy link
Member

That should be v1.1.? for pattern matching:)

@jbrichau jbrichau mentioned this issue Sep 13, 2015
11 tasks
@dalehenrich
Copy link
Member

It turns out that right now Grease is referenced from the master branch:

        baseline: 'Grease'
          with: [ 
              spec
                loads: #('Core');
                repository: 'github://GsDevKit/Grease:master/repository' ];

And this was done about a year ago: 0b064f9. Same timeframe as original bug report ... so we must have crossed wires back then..GsUpgrader uses the master branch as well ...

Sooo I think we're good ... if not we can discuss in more detail ...

dalehenrich added a commit that referenced this issue Mar 29, 2021
implement #close in ZipArchive family
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants