Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class>>removeFromSystem silently skips removal if there are subclasses #73

Closed
dalehenrich opened this issue Sep 11, 2015 · 0 comments
Closed

Comments

@dalehenrich
Copy link
Member

The original code was written years ago and it is likely that I duplicated the GBS logic - they have a similar restriction ...

There is no real harm in removing a class from Smalltalk when it has subclasses other than it is hard to find the class if you want it back for some reason:) - the system continues to function, only lookups will start failing ...

I raise this issue because "silently" failing to remove a class could be a source of Monticello load/unload issues and since I am opening up the [bugfix sweep pull request}(https://github.com/glassdb/pull/3) this might be a good time to put in some tests to a) prove that is can cause problems or b) see what havoc would be wreaked by making it an error or c) silently remove the requirement and move forward with life

@dalehenrich dalehenrich mentioned this issue Sep 11, 2015
11 tasks
dalehenrich added a commit to glassdb/glass that referenced this issue Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant