Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAStringReader>>visitNumberDescription broken #75

Closed
IwanVosloo opened this issue Sep 14, 2015 · 2 comments
Closed

MAStringReader>>visitNumberDescription broken #75

IwanVosloo opened this issue Sep 14, 2015 · 2 comments

Comments

@IwanVosloo
Copy link

This method calls NumberParser class>>isNumber: which in turn calls class side methods that are not implemented on NumberParser in GemStone (yet they are implemented on Pharo).

Observed with:
GemStone 3.2.6 (64bit)
Seaside 3.1.4
Magritte 3.3.1, 3.3.2, 3.5

@dalehenrich dalehenrich mentioned this issue Sep 15, 2015
11 tasks
IwanVosloo pushed a commit to finworks/glass that referenced this issue Sep 15, 2015
…lass, using a defaultParserClass for class methods (fixes GsDevKit#75)
IwanVosloo pushed a commit to finworks/glass that referenced this issue Sep 15, 2015
…lass, using a defaultParserClass for class methods (fixes GsDevKit#75)
IwanVosloo pushed a commit to finworks/glass that referenced this issue Sep 15, 2015
…Parser were a concrete class, using a defaultParserClass (fixes GsDevKit#75)
IwanVosloo pushed a commit to finworks/glass that referenced this issue Sep 15, 2015
…Parser were a concrete class, using a defaultParserClass (fixes GsDevKit#75)
dalehenrich added a commit to glassdb/glass that referenced this issue Sep 15, 2015
Fix for issue GsDevKit#75 ... perfect the tests all passed this time as well ...
dalehenrich added a commit to glassdb/glass that referenced this issue Sep 15, 2015
…e used as if NumberParser were a concrete class, using a defaultParserClass (fixes GsDevKit#75) from Ilwan ... update the monticello meta data ...
dalehenrich added a commit to glassdb/glass that referenced this issue Sep 15, 2015
dalehenrich added a commit to glassdb/glass that referenced this issue Sep 15, 2015
…eak.v32 and Squeak.v33 packages from Squeakv.3
dalehenrich added a commit to glassdb/glass that referenced this issue Sep 15, 2015
dalehenrich added a commit to glassdb/glass that referenced this issue Sep 15, 2015
…nitialization of DefaultParserClass class var in NumberParser ... just answer default class
dalehenrich added a commit to glassdb/glass that referenced this issue Sep 15, 2015
…ak.v32 and Squeak.v3 packages from Squeak.v33
dalehenrich added a commit to glassdb/glass that referenced this issue Oct 7, 2015
dalehenrich added a commit to glassdb/glass that referenced this issue May 16, 2016
…er parser class instead of NumberParser or SqNumberParser ...
dalehenrich added a commit to glassdb/glass that referenced this issue May 16, 2016
…er parser class instead of NumberParser or SqNumberParser ...
dalehenrich added a commit to glassdb/glass that referenced this issue May 16, 2016
dalehenrich added a commit to glassdb/glass that referenced this issue May 16, 2016
@marianopeck
Copy link

Hi guys,

I just found this very same issue but after reading this entry as well as the referenced issues I am still not sure how it was finally fixed.

Magritte 3 (both, either GsDevKit repo or shub) continue doing NumberParser isNumber: self contents. in MAStringReader>>visitNumberDescription, and my latest GemStone 3.3 does not implement NumberParser class >> isNumber. So...where should the fix be?

Thanks in advance

@marianopeck
Copy link

For the record, I just tried upgrading GLASS just in case but still, no isNumber:.

	Gofer new
	package: 'GsUpgrader-Core';
	url: 'http://ss3.gemtalksystems.com/ss/gsUpgrader';
	load.
	(Smalltalk at: #GsUpgrader)
	    upgradeGLASS;
	    upgradeGLASS1;
	    upgradeMetacello;
	    upgradeGrease.

Sure, I can add it myself to my compatibility packages...but just wanted to know if I was missing something..

dalehenrich added a commit to glassdb/glass that referenced this issue Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants