Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong version used in example #82

Closed
dalehenrich opened this issue Mar 19, 2016 · 3 comments
Closed

wrong version used in example #82

dalehenrich opened this issue Mar 19, 2016 · 3 comments
Assignees

Comments

@dalehenrich
Copy link
Member

doru was following an example and had the download fail, because the version number used was 3.3 instead of 3.3.0 ... I'll fix that one and any other obvious places ... presumably there could be a bunch of places where the version number was incorrectly updated

@dalehenrich
Copy link
Member Author

@LisaAlmarode I may have caught the only place where this change was made with 71bb979 ... there might be more in your dev branch ... once you've cleaned up, I will want to think about the download script and possibly allow for 3.3 as a version number arg - this won't be easy, because the version number is used as an index into the product downloads and we don't name our downloads with only major and minor version numbers ... but I want to think about it anyway ...

@dalehenrich
Copy link
Member Author

20d7c7c should have gotten all of the changes that were made in your last merge ...

LisaAlmarode added a commit to LisaAlmarode/GsDevKit_home that referenced this issue Mar 22, 2016
dalehenrich added a commit that referenced this issue Mar 22, 2016
@LisaAlmarode
Copy link
Contributor

Fixed in pull request #84
versions 3.3 changed to 3.3.0, Dale has agreed that devKit_33 is not unacceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants