Issue #10: need to load #previewBootstrap before Gofer and before att…

…tempting to load MetacelloPreview
GsDevKit · Oct 17, 2014 · 8bfcff0 · 8bfcff0
1 parent 55d6193
commit 8bfcff0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/repository/GsUpgrader-Core.package/GsUpgrader.class/instance/upgradeGLASS.st b/repository/GsUpgrader-Core.package/GsUpgrader.class/instance/upgradeGLASS.st
@@ -49,7 +49,15 @@ upgradeGLASS
               ((Smalltalk at: #'ConfigurationOfGLASS') project
                 version: '1.0-beta.9.2') load ]
                 on: (Smalltalk at: #'MetacelloSkipDirtyPackageLoad')
-                do: [ :ex | ex resume: false ] ].
+                do: [ :ex | ex resume: false ] ]
+            ifFalse: [ 
+              "explicitly load Metacello #previewBootstrap"
+              Gofer new
+                url: 'http://seaside.gemtalksystems.com/ss/metacello';
+                package: 'ConfigurationOfMetacello';
+                load.
+              ((Smalltalk at: #'ConfigurationOfMetacello') project
+                version: #'previewBootstrap') load ].
           self upgradeGofer.
           ((Smalltalk at: #'ConfigurationOfGLASS') project
             version: '1.0-beta.9.3') load.

diff --git a/repository/GsUpgrader-Core.package/GsUpgrader.class/methodProperties.json b/repository/GsUpgrader-Core.package/GsUpgrader.class/methodProperties.json
@@ -34,7 +34,7 @@
 		"projectVersion:" : "dkh 09/15/2014 13:13",
 		"standardBaselineLoaded:" : "dkh 09/11/2014 09:45",
 		"standardUpgrade:repository:" : "dkh 09/24/2014 10:45",
-		"upgradeGLASS" : "dkh 10/16/2014 13:45",
+		"upgradeGLASS" : "dkh 10/16/2014 17:06",
 		"upgradeGLASS1" : "dkh 09/11/2014 09:48",
 		"upgradeGofer" : "dkh 10/16/2014 13:13",
 		"upgradeGrease" : "dkh 09/12/2014 10:48",

diff --git a/repository/GsUpgrader-Core.package/monticello.meta/version b/repository/GsUpgrader-Core.package/monticello.meta/version
@@ -1 +1 @@
-(name 'GsUpgrader-Core-dkh.36' message 'Issue #10: have to be at GLASS1.0-beta.9.2 before calling upgradeGofer' id '4cf35d8b-5387-4131-847e-f9672b0eccdb' date '10/16/2014' time '13:46:20' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.35' message 'Issue #10: ensure that Gofer #stable (1.0.5.3 right now) is loaded before upgrading to GLASS1.0-beta.9.3 and the Metacello Preview. part of bugfix for https://github.com/dalehenrich/metacello-work/issues/301' id '7f359b72-55db-47e8-9a77-c1d8871a562c' date '10/16/2014' time '13:22:28' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.34' message 'Issue #3: whoops need to use the method #metacelloClass and avoid direct refs to the Metacello class' id '15a76465-f68e-4f1b-bb9a-0718c67de250' date '10/12/2014' time '15:27:33' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.33' message 'Issue #6: avoid offset error when Grease project is not registered' id '90ad0f48-38b4-48c1-a6da-92dea55f670f' date '09/24/2014' time '10:48:15' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.32' message 'Issue #3: need to patch the repository for the Gs* project registrations to make sure that http://seaside.gemtalksystems.com/ss/MetacelloRepository is referenced. This is a side effect of the original boot strapping process when building extent0.seaside.dbf' id 'b2a2b00c-83be-4e8a-b40b-c4d8602d1973' date '09/20/2014' time '13:53:08' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.31' message 'loadMetacelloBootstrap10beta311 must be inside a deploy block ...' id '7ba51940-228e-453e-8fc3-237ca27676de' date '09/16/2014' time '13:10:49' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.30' message 'formalize the need to bootstrap Metacello1.0-beta.31.1 ... shared between upgradeGLASS and upgradeMetacello' id '1850d2eb-1b5f-448e-8b2c-7e13b44e446f' date '09/16/2014' time '11:23:36' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.29' message 'bootstrap Metacello #previewBootstrap BEFORE attempting to load GLASS 1.0-beta.9.2, since Grease uses new construct (issue in GemStone 3.1.0.2 only)' id '93ce76e1-2a99-4cbb-bfd0-91733732d855' date '09/15/2014' time '14:32:50' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.28' message 'portability to even older versions of glass (1.0-beta.8.1)' id '61908901-b01b-47d6-84d8-8b538bdb60c8' date '09/15/2014' time '13:50:57' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.27' message 'use up-to-date url for gemsource' id '56891dae-aa75-42e1-99cc-5a5d8aeaf7b7' date '09/15/2014' time '13:39:58' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.26' message 'fix logic error' id '52dad071-ac5d-451a-bad5-4fedccccefdf' date '09/15/2014' time '13:36:34' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.25' message 'more logging' id 'ab2a3634-94f2-45b4-91a5-0f2c6b7719e5' date '09/15/2014' time '13:30:45' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.24' message 'logging' id 'e1adaebc-46e0-4daa-8b92-d2954aeea45b' date '09/15/2014' time '13:27:26' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.23' message 'record some state ... metacello version is "wrong" in 3.1.0.2 gemstone ...' id 'b78a3bfb-723d-4c86-a18f-3602dbd49fa7' date '09/15/2014' time '13:24:04' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.22' message 'better job getting version of project ... conditional upon whether metacello registry is in use or not ...' id '22cfb9fb-ed0c-486f-8758-2b6ab1ff0db6' date '09/15/2014' time '13:20:24' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.21' message 'have to make sure that Metacello is loaded independently of Grease, since recent Grease configuration requires metacello to be loaded ... part of pre GLASS1.0-beta.8.7.1 support' id 'feaa31c0-275e-4c15-9cb8-f4661ec7b10e' date '09/15/2014' time '11:54:09' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.20' message '...and more pre GLASS1.0-beta.8.7.1 support' id '76414e4d-4169-428d-9051-c85ecdb6128f' date '09/15/2014' time '11:43:36' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.19' message 'and more pre GLASS1.0-beta.8.7.1 support' id 'd0f28732-4870-4dee-a332-3db1fb63b903' date '09/15/2014' time '11:40:45' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.18' message 'still more pre GLASS1.0-beta.8.7.1 support' id '4d8e25fe-a3d2-4cde-90d9-8e1e18be0b8a' date '09/15/2014' time '11:32:36' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.17' message 'more pre GLASS1.0-beta.8.7.1 logic...' id 'aa3a6b8a-2f1a-490b-84c3-a737c50ce6a7' date '09/15/2014' time '11:23:28' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.16' message 'fix upgradeGLASS logic for upgrading pre GLASS1.0-beta-8.7.1 versions' id '1eb891d5-ff0f-4f8d-aa9d-4ec2107b0fbf' date '09/15/2014' time '11:06:04' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.15' message 'fix Grease loader logic ... failure when Grease baseline not loaded yet ...' id '12cc2463-06a6-4196-9318-ee08f0d6a5b1' date '09/12/2014' time '10:51:12' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.14' message 'fix coding error' id '3f691837-a369-4ec8-8279-2582135983b6' date '09/12/2014' time '10:24:34' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.13' message 'put ''|'' around name of locked projects and bracket unloaded projects with ''<>''' id 'bbcfaebc-199d-4f09-98a3-470ec9afff2e' date '09/12/2014' time '10:12:03' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.12' message 'add GsUpgrader class>>metacelloReport for use in diagnosing load issues' id 'cbc58b89-9ebd-4e5b-8a3e-b28f9e01eda7' date '09/11/2014' time '17:04:18' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.11' message 'add #upgradeGRease entry point ... class comment ... checkpoint for improved documentation' id '828b666b-be25-41eb-b678-7949174cb20e' date '09/11/2014' time '14:51:59' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.10' message 'add some code that''s probably necessary to upgrade from 1.0-beta.8.7.1 (earliest supported GLASS version of GsUpgrader)' id '95bdce96-8513-46bf-80d5-fa3cd06c9128' date '09/10/2014' time '16:10:59' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.9' message 'replace direct references to Metacello with a messge send ... more friendly for older versions' id '31f8aaf0-368b-4f6c-9c56-3549b27ab630' date '09/10/2014' time '15:04:05' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.8' message 'if MetacelloPreview is already loaded then no need to upgrade to 1.0-beta.9.3' id 'e5c99d83-0826-4024-a17c-82de2b7af6cf' date '09/10/2014' time '12:47:36' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.7' message 'straighten up logging for GsUpgrader' id '0d60194e-6770-4dd7-95b9-148b12bb0090' date '09/05/2014' time '16:58:03' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.6' message 'fix typo' id '602c0148-c6b0-43e8-808f-179dd5ccbd58' date '09/05/2014' time '16:48:04' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.5' message 'if GLASS1 or Metacello baselines are not locked, then force the load from the proper github master repository' id '736acf8b-9cac-4d4d-9760-d25fd7662277' date '09/05/2014' time '16:45:42' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.4' message 'fix the uses of the `list` command' id '2a427973-bdc8-41cb-9718-0fe8ec55c3c5' date '09/05/2014' time '16:30:32' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.3' message 'adjust GsUpgrader to work on older versions of Metacello' id '9f412a77-80c0-49c2-b947-c8c24b3b9789' date '09/05/2014' time '16:19:43' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.2' message 'implement GsUpgrader' id '878e4cb3-db47-4a22-a324-f07713c295be' date '09/05/2014' time '14:35:40' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.1' message 'bump' id '65ff9dcf-cb57-4680-af32-e7040989c4dd' date '09/05/2014' time '11:50:13' author 'dkh' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())
+(name 'GsUpgrader-Core-dkh.37' message 'Issue #10: need to load #previewBootstrap before Gofer and before atttempting to load MetacelloPreview' id 'ad40c941-fb3f-4f37-8d66-7a15d895c0e0' date '10/16/2014' time '17:09:20' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.36' message 'Issue #10: have to be at GLASS1.0-beta.9.2 before calling upgradeGofer' id '4cf35d8b-5387-4131-847e-f9672b0eccdb' date '10/16/2014' time '13:46:20' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.35' message 'Issue #10: ensure that Gofer #stable (1.0.5.3 right now) is loaded before upgrading to GLASS1.0-beta.9.3 and the Metacello Preview. part of bugfix for https://github.com/dalehenrich/metacello-work/issues/301' id '7f359b72-55db-47e8-9a77-c1d8871a562c' date '10/16/2014' time '13:22:28' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.34' message 'Issue #3: whoops need to use the method #metacelloClass and avoid direct refs to the Metacello class' id '15a76465-f68e-4f1b-bb9a-0718c67de250' date '10/12/2014' time '15:27:33' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.33' message 'Issue #6: avoid offset error when Grease project is not registered' id '90ad0f48-38b4-48c1-a6da-92dea55f670f' date '09/24/2014' time '10:48:15' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.32' message 'Issue #3: need to patch the repository for the Gs* project registrations to make sure that http://seaside.gemtalksystems.com/ss/MetacelloRepository is referenced. This is a side effect of the original boot strapping process when building extent0.seaside.dbf' id 'b2a2b00c-83be-4e8a-b40b-c4d8602d1973' date '09/20/2014' time '13:53:08' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.31' message 'loadMetacelloBootstrap10beta311 must be inside a deploy block ...' id '7ba51940-228e-453e-8fc3-237ca27676de' date '09/16/2014' time '13:10:49' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.30' message 'formalize the need to bootstrap Metacello1.0-beta.31.1 ... shared between upgradeGLASS and upgradeMetacello' id '1850d2eb-1b5f-448e-8b2c-7e13b44e446f' date '09/16/2014' time '11:23:36' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.29' message 'bootstrap Metacello #previewBootstrap BEFORE attempting to load GLASS 1.0-beta.9.2, since Grease uses new construct (issue in GemStone 3.1.0.2 only)' id '93ce76e1-2a99-4cbb-bfd0-91733732d855' date '09/15/2014' time '14:32:50' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.28' message 'portability to even older versions of glass (1.0-beta.8.1)' id '61908901-b01b-47d6-84d8-8b538bdb60c8' date '09/15/2014' time '13:50:57' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.27' message 'use up-to-date url for gemsource' id '56891dae-aa75-42e1-99cc-5a5d8aeaf7b7' date '09/15/2014' time '13:39:58' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.26' message 'fix logic error' id '52dad071-ac5d-451a-bad5-4fedccccefdf' date '09/15/2014' time '13:36:34' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.25' message 'more logging' id 'ab2a3634-94f2-45b4-91a5-0f2c6b7719e5' date '09/15/2014' time '13:30:45' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.24' message 'logging' id 'e1adaebc-46e0-4daa-8b92-d2954aeea45b' date '09/15/2014' time '13:27:26' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.23' message 'record some state ... metacello version is "wrong" in 3.1.0.2 gemstone ...' id 'b78a3bfb-723d-4c86-a18f-3602dbd49fa7' date '09/15/2014' time '13:24:04' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.22' message 'better job getting version of project ... conditional upon whether metacello registry is in use or not ...' id '22cfb9fb-ed0c-486f-8758-2b6ab1ff0db6' date '09/15/2014' time '13:20:24' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.21' message 'have to make sure that Metacello is loaded independently of Grease, since recent Grease configuration requires metacello to be loaded ... part of pre GLASS1.0-beta.8.7.1 support' id 'feaa31c0-275e-4c15-9cb8-f4661ec7b10e' date '09/15/2014' time '11:54:09' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.20' message '...and more pre GLASS1.0-beta.8.7.1 support' id '76414e4d-4169-428d-9051-c85ecdb6128f' date '09/15/2014' time '11:43:36' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.19' message 'and more pre GLASS1.0-beta.8.7.1 support' id 'd0f28732-4870-4dee-a332-3db1fb63b903' date '09/15/2014' time '11:40:45' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.18' message 'still more pre GLASS1.0-beta.8.7.1 support' id '4d8e25fe-a3d2-4cde-90d9-8e1e18be0b8a' date '09/15/2014' time '11:32:36' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.17' message 'more pre GLASS1.0-beta.8.7.1 logic...' id 'aa3a6b8a-2f1a-490b-84c3-a737c50ce6a7' date '09/15/2014' time '11:23:28' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.16' message 'fix upgradeGLASS logic for upgrading pre GLASS1.0-beta-8.7.1 versions' id '1eb891d5-ff0f-4f8d-aa9d-4ec2107b0fbf' date '09/15/2014' time '11:06:04' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.15' message 'fix Grease loader logic ... failure when Grease baseline not loaded yet ...' id '12cc2463-06a6-4196-9318-ee08f0d6a5b1' date '09/12/2014' time '10:51:12' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.14' message 'fix coding error' id '3f691837-a369-4ec8-8279-2582135983b6' date '09/12/2014' time '10:24:34' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.13' message 'put ''|'' around name of locked projects and bracket unloaded projects with ''<>''' id 'bbcfaebc-199d-4f09-98a3-470ec9afff2e' date '09/12/2014' time '10:12:03' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.12' message 'add GsUpgrader class>>metacelloReport for use in diagnosing load issues' id 'cbc58b89-9ebd-4e5b-8a3e-b28f9e01eda7' date '09/11/2014' time '17:04:18' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.11' message 'add #upgradeGRease entry point ... class comment ... checkpoint for improved documentation' id '828b666b-be25-41eb-b678-7949174cb20e' date '09/11/2014' time '14:51:59' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.10' message 'add some code that''s probably necessary to upgrade from 1.0-beta.8.7.1 (earliest supported GLASS version of GsUpgrader)' id '95bdce96-8513-46bf-80d5-fa3cd06c9128' date '09/10/2014' time '16:10:59' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.9' message 'replace direct references to Metacello with a messge send ... more friendly for older versions' id '31f8aaf0-368b-4f6c-9c56-3549b27ab630' date '09/10/2014' time '15:04:05' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.8' message 'if MetacelloPreview is already loaded then no need to upgrade to 1.0-beta.9.3' id 'e5c99d83-0826-4024-a17c-82de2b7af6cf' date '09/10/2014' time '12:47:36' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.7' message 'straighten up logging for GsUpgrader' id '0d60194e-6770-4dd7-95b9-148b12bb0090' date '09/05/2014' time '16:58:03' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.6' message 'fix typo' id '602c0148-c6b0-43e8-808f-179dd5ccbd58' date '09/05/2014' time '16:48:04' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.5' message 'if GLASS1 or Metacello baselines are not locked, then force the load from the proper github master repository' id '736acf8b-9cac-4d4d-9760-d25fd7662277' date '09/05/2014' time '16:45:42' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.4' message 'fix the uses of the `list` command' id '2a427973-bdc8-41cb-9718-0fe8ec55c3c5' date '09/05/2014' time '16:30:32' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.3' message 'adjust GsUpgrader to work on older versions of Metacello' id '9f412a77-80c0-49c2-b947-c8c24b3b9789' date '09/05/2014' time '16:19:43' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.2' message 'implement GsUpgrader' id '878e4cb3-db47-4a22-a324-f07713c295be' date '09/05/2014' time '14:35:40' author 'dkh' ancestors ((name 'GsUpgrader-Core-dkh.1' message 'bump' id '65ff9dcf-cb57-4680-af32-e7040989c4dd' date '09/05/2014' time '11:50:13' author 'dkh' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())