Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 104 #105

Merged
merged 3 commits into from
May 26, 2024
Merged

Fix issue 104 #105

merged 3 commits into from
May 26, 2024

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented May 26, 2024

Fix for issue #104.

I defined a rest handler that serves a large (55MB) text file:

get

	<get>
	<path: '/'>
	<produces: 'application/json'>

	| file |
	file := GsFile openReadOnServer: 'largefile.txt'.
	^ file contents

before the fix, it takes +-35s to respond:

johanbrichau@JohansMacBookAir ~ % time curl http://localhost:8383/test --output bla.txt
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 55.2M  100 55.2M    0     0  1543k      0  0:00:36  0:00:36 --:--:-- 12.8M
curl http://localhost:8383/test --output bla.txt  0.01s user 0.05s system 0% cpu 36.698 total

after the fix, it takes 1.5s to respond:

johanbrichau@JohansMacBookAir ~ % time curl http://localhost:8383/test --output bla.txt
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 55.2M  100 55.2M    0     0  33.9M      0  0:00:01  0:00:01 --:--:-- 33.9M
curl http://localhost:8383/test --output bla.txt  0.01s user 0.05s system 3% cpu 1.653 total

…ext:putAll:startingAt: which was introduced in commit cbddf8b
@jbrichau jbrichau changed the base branch from master to gs_master May 26, 2024 10:28
@jbrichau
Copy link
Member Author

The failing test testAmazonAWS is also failing without the changes made in this PR. It was working last month (see CI actions history) but it's now failing with "SSL alert number 40".

I also did manual tests with Seaside, which revealed no issues.

@jbrichau jbrichau merged commit 5c46bab into gs_master May 26, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant