Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsVisible vs Visibility in Readme.md documentation #33

Closed
stevemonaco opened this issue Sep 30, 2020 · 3 comments
Closed

IsVisible vs Visibility in Readme.md documentation #33

stevemonaco opened this issue Sep 30, 2020 · 3 comments

Comments

@stevemonaco
Copy link
Contributor

I cannot bind .IsVisible as described by the samples shown by Overlay and Info since IsVisible is read-only.

<Rectangle
	adorners:Info.IsVisible="True"

Results in the error message: Error MC3065 'Info.IsVisible' property is read-only and cannot be set from markup.

I believe they should be changed to .Visibility as mentioned by the 2.0 breaking change.
@FoggyFinder
Copy link
Contributor

Yep. Would you mind to open PR or you prefer that someone else fix it ?

@stevemonaco
Copy link
Contributor Author

I can PR it in a day or so, if needed. It looks like the samples were taken from the (now updated) demo apps.

@stevemonaco stevemonaco mentioned this issue Sep 30, 2020
Merged
FoggyFinder added a commit that referenced this issue Oct 1, 2020
@FoggyFinder
Merge pull request #34 from stevemonaco/master
7fe3699 
Fix Readme.md documentation error: IsVisible to Visibility #33
@FoggyFinder
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevemonaco @FoggyFinder