Reinstate double click to open tabs

With an additional condition to attempt to check that we're clicking on the tab bar to resolve the original issue that led to the removal of the feature.
Guake · Jan 18, 2022 · 9ec94c5 · 9ec94c5
1 parent 0858d25
commit 9ec94c5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/guake/notebook.py b/guake/notebook.py
@@ -120,6 +120,13 @@ def on_button_press(self, target, event, user_data):
             except AttributeError:
                 # Gtk 3.18 fallback ("'Menu' object has no attribute 'popup_at_pointer'")
                 menu.popup(None, None, None, None, event.button, event.time)
+        elif (
+            event.type == Gdk.EventType.DOUBLE_BUTTON_PRESS
+            and event.button == 1
+            and event.window.get_height() < 60
+        ):
+            # event.window.get_height() reports the height of the clicked frame
+            self.new_page_with_focus()
 
         return False
 

diff --git a/releasenotes/notes/restore_double_click_open_tab-c4dfc824ce4b5e85.yaml b/releasenotes/notes/restore_double_click_open_tab-c4dfc824ce4b5e85.yaml
@@ -0,0 +1,7 @@
+release_summary: >
+  Reinstated double clicking to open new tabs
+
+features:
+  - |
+      - Double click to open a new tab, without side effects in mouse
+        enabled terminal apps