Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gtk3] Invalid shortcuts #1098

Closed
egmontkob opened this issue Jan 15, 2018 · 2 comments
Closed

[gtk3] Invalid shortcuts #1098

egmontkob opened this issue Jan 15, 2018 · 2 comments
Milestone

Comments

@egmontkob
Copy link

Some lines from guake/data/org.guake.gschema.xml:

    <key name="move-tab-left" type="s">
        <default>'&lt;Control&gt;Shift&gt;Page_Up'</default>

    <key name="move-tab-right" type="s">
        <default>'&lt;Control&gt;Shift&gt;Page_Down'</default>

    <key name="increase-transparency" type="s">
        <default>'&lt;Control&gt;Shift&gt;Up'</default>

    <key name="decrease-transparency" type="s">
        <default>'&lt;Control&gt;Shift&gt;Down'</default>

    <key name="toggle-transparency" type="s">
        <default>'&lt;Control&gt;Alt&gt;T'</default>

Note how &lt; and &gt; are unbalanced, the opening &lt; is missing from the second modifier.

@egmontkob
Copy link
Author

Interestingly, "Increase transparency" and "Decrease transparency" initially show up as "Disabled" in the keyboard shortcut editor, but if I modify them to their intended default then they're shown as "Invalid" instead.

"Increase/Decrease height" are presented as "Invalid" initially.

@gsemet gsemet added this to the 3.0.2 milestone Jan 16, 2018
@gsemet
Copy link
Member

gsemet commented Jan 16, 2018

oh, nice catch. i does the fix the other exception with modifier, unfortunately

gsemet added a commit that referenced this issue Jan 16, 2018
gsemet added a commit that referenced this issue Jan 17, 2018
gsemet added a commit that referenced this issue Jan 17, 2018
@gsemet gsemet closed this as completed in ac0a4c2 Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants