Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitting terminal should not reset font size #1747

Closed
giuspe opened this issue Apr 14, 2020 · 6 comments
Closed

splitting terminal should not reset font size #1747

giuspe opened this issue Apr 14, 2020 · 6 comments

Comments

@giuspe
Copy link

giuspe commented Apr 14, 2020

(this is somehow halfway between a feature and a bug)

the problem

whenever I split a terminal tab (horizontally or vertically) the font size of all split spaces gets reset to default font size.

the behaviour is the same when splitting via keyboard or using the right-click menu.

the behaviour doesn't happen when closing a previously created split space.

how to reproduce

  1. open a new terminal tab (or reuse an already opened one)
  2. adjust font size (CTRL + / CTRL -) changing from default
  3. split the terminal tab

expected result

the terminal tab is split, no other changes are applied.

actual result

the terminal tab is split and font size is reset to default (as defined in settings) for all terminal tab sections

environment information

Guake Terminal: 3.6.3
VTE: 0.58.3
VTE runtime: 0.58.3
Gtk: 3.24.13

LInux Fedora 31
GNOME Shell 3.34.5

@ujjwaltwitx
Copy link

I would like to work on this issue.

@Davidy22
Copy link
Collaborator

Davidy22 commented Oct 3, 2021

Sure, I'll assign you since you asked and all. Make sure to follow the instructions in the PR template once you get this done and pushing.

@Davidy22
Copy link
Collaborator

Unassigning because it's been months without contact

@ChristianCelora
Copy link
Contributor

Hello, i would like to try resolve the issue.

@Davidy22
Copy link
Collaborator

Davidy22 commented Feb 9, 2022

If you want to work on this, feel free to make a pull request once you're done.

ChristianCelora added a commit to ChristianCelora/guake that referenced this issue Feb 25, 2022
ChristianCelora added a commit to ChristianCelora/guake that referenced this issue Feb 25, 2022
This reverts commit be570b9.
ChristianCelora added a commit to ChristianCelora/guake that referenced this issue Feb 25, 2022
ChristianCelora added a commit to ChristianCelora/guake that referenced this issue Mar 21, 2022
improved solution after pr review

comment indented due to PEP-08
ChristianCelora added a commit to ChristianCelora/guake that referenced this issue Mar 21, 2022
improved solution after pr review

comment indented due to PEP-08
ChristianCelora added a commit to ChristianCelora/guake that referenced this issue Apr 8, 2022
Now it preverse the font scale during a vertical / horizontal split.
Resolve issue Guake#1747.
Davidy22 pushed a commit that referenced this issue Apr 9, 2022
Now it preverse the font scale during a vertical / horizontal split.
Resolve issue #1747.
@Davidy22
Copy link
Collaborator

Davidy22 commented Apr 9, 2022

Resolved in #2046

@Davidy22 Davidy22 closed this as completed Apr 9, 2022
PhungXuanAnh pushed a commit to PhungXuanAnh/guake that referenced this issue Oct 28, 2023
Now it preverse the font scale during a vertical / horizontal split.
Resolve issue Guake#1747.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants