Fix ignored "Show scrollbar" after spliting vertically #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeusintuivo
added a commit
to zeusintuivo/guake
that referenced
this pull request
Jul 11, 2020
Davidy22
requested changes
Sep 8, 2021
There was a problem hiding this comment.
Hello, ran the patch and it does what it says it does, the changes look fine and this passes our fixed CI, only thing left is it would be nice if you could create a release notes file with
make reno SLUG=fix_ignored_show_scrollbar_when_splitting
And fill in the relevant sections, delete the irrelevant ones, etc.
|
I am not interested in pushing this fix forward anymore, so if you need it then feel free to finish my PR |
Davidy22
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1734