Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update news file #1951

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Update news file #1951

merged 1 commit into from
Nov 13, 2021

Conversation

Davidy22
Copy link
Collaborator

Prep for release

NEWS.rst Outdated
@@ -100,6 +134,10 @@ New Features
Known Issues
------------

- - None

- - None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is cause by auto generated?

Copy link
Collaborator Author

@Davidy22 Davidy22 Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trimming those out is going to get tiresome, should maybe go into the release notes files sometime and remove the bits that those are being taken from. Or switch to one of the newer fangled release notes generators that use commit messages maybe. Removed these for now.

@Davidy22
Copy link
Collaborator Author

Alright for now I'm just going to tag the release and people can get the changelog from here, not going to wait another 4 days for a news file change to get approved

@Davidy22
Copy link
Collaborator Author

Since this is overdue for 3.8.1 anyways, I'm going to take this chance to reform this PR into cutting those annoying none lines that I've added before

@Davidy22
Copy link
Collaborator Author

@mlouielu This and a bunch of other PRs have been sitting for two weeks, can they get looked at eventually?

@gsemet can we get the maintainer transition progressed a little bit? Commits get deadlocked for weeks because we can't merge our own work, and a litany of external tools still need to be troubleshot by telegraph because we can't access them. How's the progress on readthedocs?

@gsemet
Copy link
Member

gsemet commented Nov 13, 2021

Hi. You are pretty much autonomous on the review and merge of the patches, I do not see what you would like more ? I can pass you as administrator of the site so you can merge your patches after a few days without reviews.
Most of the time I do not get the notification so you need to @ me manually or I do not see the MR…
For the release process, you (both of you actually) need to rework it and improve it.

@gsemet gsemet merged commit 18a36e4 into Guake:master Nov 13, 2021
@gsemet
Copy link
Member

gsemet commented Nov 13, 2021

Admin permission granted

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Nov 15, 2021

The main peeve was waiting indeterminate amounts of time for my code changes to get merged or just responded to making it difficult to actively work on Guake because anything I write just sits inert if the other two people who can review don't log into github. Thanks for the permissions, @mlouielu may need them too if I go absentee because he can't get anything into the code either without a reviewer.

Been throwing attempts at the automated release process periodically, you can see where I'm at and my prior output here, if anyone's got it figured out I'm very interested in seeing what they got.

@gsemet
Copy link
Member

gsemet commented Nov 15, 2021

With poetry and poetry-dynamic-versioning, things are easier. It replaces pipenv and pbr, so package are more « standard ».
The good added value would be to have a complete release triggered on a single tag (without the need to update manually the release note,…). For example we put a tag and the release pipeline use the GitHub api to put the release description. We simply edit it after and add a little intro…

@Davidy22 Davidy22 deleted the news branch November 15, 2021 08:39
@Davidy22
Copy link
Collaborator Author

Getting fairly tempted to do the poetry switch to try solve this, will try that if I still can't make it work.

@Davidy22
Copy link
Collaborator Author

So I am getting a little frustrated with this, but it's more to do with pytest really than pipenv I think. Might give it a rest till my next attempt, but all my failed runs are probably visible on my branch

@mlouielu mlouielu added this to the 3.8.2 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants