Use keycode for keybindings

[vantu5z]

Try to fix #1946.

[Davidy22]

As I don't have an affected keyboard, I can't confirm that this fixes the issue, but upon quick testing it doesn't break my own keybindings so this approach at least seems to operate generally correctly. Has less specific logic too which is nice. I presume as the submitter of the original issue that this works for you?

Once I get some confirmation that this fixes the issue I just need you to do a make reno SLUG=use_keycode_for_keybindings and fill the in relevant sections, delete the irrelevant ones and I'll merge. I can fill in the release notes file later myself if I get the time.

[vantu5z]

I just need you to do a make reno SLUG=use_keycode_for_keybindings and fill the in relevant sections, delete the irrelevant ones

Can you look if I do it right?

I presume as the submitter of the original issue that this works for you?

Yes, it works for me. And it allow to add keybindings using non English layout (language) too and it will work with English.

Anyway I have some doubt about Gtk.accelerator_parse_with_keycode(accelerator) as documentation says that we should not use it with not system-level components, but as we choose key-press-event way for keybindings I think we can use it.

Another place of possible issue - accelerator_parse_with_keycode returns accelerator_codes list. For now I use the first item from list, but I think this list can differ depending on the system configuration. Or list variable used because accelerator_codes try to be parsed by multiple ways and keycodes will be identical in the list (for me is only one item in this list).

[Davidy22]

I believe the first one in the list is the one that would be expressed in a text editor and expected by the user, so the first one should be fine. Release note file looks good, merging.

[fx-kirin]

This change breaks shortcut with custom key mapping through xkb. It would be nicer there is an option to choose the behavior.

This #2058 might be a case too.