Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix module gi not found when make run " #1992

Merged
merged 3 commits into from
Dec 19, 2021

Conversation

mlouielu
Copy link
Collaborator

Reverts #1989

We will revise this in #1990

@Davidy22
Copy link
Collaborator

We can just fix it in the other PR and skip this revert step, can we not?

Copy link
Collaborator

@Davidy22 Davidy22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After investigation into error messages on other probably affected PRs, I see reports that a regression past 2018.11.26 is probably causing these issues so I'll second this and send this back to the drawing board.

@Davidy22 Davidy22 merged commit 974c90e into master Dec 19, 2021
@mlouielu mlouielu deleted the revert-1989-fix/gi-not-found-on-run-local branch December 19, 2021 02:02
@Davidy22 Davidy22 mentioned this pull request Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants