Eliminate redundant terminal spawning #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidy22
force-pushed
the
spawn
branch
2 times, most recently
from
4ba711e
to
a35dfe0
Compare
mlouielu
reviewed
Jan 25, 2022
|
I'll take a closer look at night. |
|
This PR is pretty solidly still a work in progress, entirely just polishing up the startup sequence a little bit. There will probably need to be checking to make sure that nothing gets regressed or broken, and there's CI errors that obviously need to get dealt with |
Davidy22
force-pushed
the
spawn
branch
4 times, most recently
from
eaffc2a
to
78aeb21
Compare
Panes are always stored even in single paned tabs, the condition gating restoring box layout is always true so the initial terminal spawned was always immediately overwritten.
|
Alright, ironed out the silly mistakes that also failed CI, now just to put this into testing/checking |
gsemet
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panes are always stored even in single paned tabs, the condition gating restoring box layout is always true so the initial terminal spawned was always immediately overwritten
No pull requests I can think of are fixed by this, although the side effects of the duplicate spawning may be the cause of some bugs. Will probably also improve startup times if user has intensive startup scripts or large save sessions