Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate release notes for 3.8.2 #2024

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Generate release notes for 3.8.2 #2024

merged 1 commit into from
Feb 2, 2022

Conversation

Davidy22
Copy link
Collaborator

Hopefully the proper release this time, unless someone decides to tag rc without saying anything again for no reason

Generated with make release-note, which was presumably how all the other release notes were generated. Note the lack of mysteriously deleted sections, which is still the main issue with #2015.

Will tag 3.8.2 when this is merged. If you merge this and tag a release, please don't leave the description empty again.

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Feb 2, 2022

@gsemet, @mlouielu, this doesn't have any code, is there anything holding up approving this?

@mlouielu
Copy link
Collaborator

mlouielu commented Feb 2, 2022

Happy Lunar New Year 😸

Give me a second for this.

Copy link
Collaborator

@mlouielu mlouielu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one spot need to clarify

NEWS.rst Show resolved Hide resolved
Copy link
Collaborator

@mlouielu mlouielu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlouielu mlouielu added this to the 3.8.2 milestone Feb 2, 2022
@mlouielu mlouielu merged commit 0b5b8f1 into Guake:master Feb 2, 2022

- Turkish (@Draconis-25, @ersen0)

3.8.2.0rc1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if the curernt release notes generator does not it, can we merge what it in the RCs and the current release?

Copy link
Collaborator Author

@Davidy22 Davidy22 Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that by removing the RC tag which may break some history, or patching the news file every time we generate it. Alternately, if you don't like seeing RCs in the news log, you can not tag them on pulls that were intended to be releases

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have what I describe at work: RCs are Ignored in the diff. So yes they can be removed, but they help test changes in the release process.

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Feb 3, 2022

Will tag 3.8.2 now that release notes are in

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Feb 3, 2022

Something about the pypi upload was messed up, might be pypi handling RCs badly. Next release we'll tag 3.9 without anyone jumping in and marking an RC and see if it works, if it marks as prerelease again then we might have a bad default set on the pypi key.

Also, how's the progress on readthedocs?

@Davidy22 Davidy22 deleted the News branch February 3, 2022 04:15
@gsemet
Copy link
Member

gsemet commented Feb 3, 2022

Looks like an issue with pbr or the checked out code in the pipeline, it has computed a wrong version in the GitHub action and uploaded a weird value. This is due to our inexperience with the GitHub workflow, not with pipy.
Should have seen that with rc, but it worked fine with the previous one…
I’ll check…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants