-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate release notes for 3.8.2 #2024
Conversation
Happy Lunar New Year 😸 Give me a second for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one spot need to clarify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
- Turkish (@Draconis-25, @ersen0) | ||
|
||
3.8.2.0rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even if the curernt release notes generator does not it, can we merge what it in the RCs and the current release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do that by removing the RC tag which may break some history, or patching the news file every time we generate it. Alternately, if you don't like seeing RCs in the news log, you can not tag them on pulls that were intended to be releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have what I describe at work: RCs are Ignored in the diff. So yes they can be removed, but they help test changes in the release process.
Will tag 3.8.2 now that release notes are in |
Something about the pypi upload was messed up, might be pypi handling RCs badly. Next release we'll tag 3.9 without anyone jumping in and marking an RC and see if it works, if it marks as prerelease again then we might have a bad default set on the pypi key. Also, how's the progress on readthedocs? |
Looks like an issue with pbr or the checked out code in the pipeline, it has computed a wrong version in the GitHub action and uploaded a weird value. This is due to our inexperience with the GitHub workflow, not with pipy. |
Hopefully the proper release this time, unless someone decides to tag rc without saying anything again for no reason
Generated with
make release-note
, which was presumably how all the other release notes were generated. Note the lack of mysteriously deleted sections, which is still the main issue with #2015.Will tag 3.8.2 when this is merged. If you merge this and tag a release, please don't leave the description empty again.