Added custom search engine input #2088 #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidy22
requested changes
Oct 18, 2022
guake/callbacks.py
Outdated
|
|
||
| selected = self.settings.general.get_int("search-engine") | ||
| # if custom search is selected, get the engine from the 'custom-search-engine' setting | ||
| if selected == 4: |
There was a problem hiding this comment.
The check for the custom option should be checking to see if it's the last index. Hardcoding to 4 can generate unexpected bugs if the list of preset search engines changes length in the future.
guake/prefs.py
Outdated
| self.get_widget("search_engine_select").set_active(value) | ||
| # if 'Custom' is selected make the search engine input editable | ||
| if value == 4: |
|
I can't find anyway to get the length of the ComboBox. Do you know of a method to do that? |
|
You can query the length of a combobox if you already have a pointer to it, but to my knowledge it's a bit ugly getting that when the combobox is nestled deep in a glade layout because there's no get element by id equivalent, but we also have the |
… Neeva search engine
|
Alright that's what I was thinking. Thanks! |
Davidy22
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added input on the general menu to add a custom search engine.