Quick Open breaks opening URL with port number #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsemet
added a commit
that referenced
this pull request
Mar 24, 2014
Quick Open breaks opening URL with port number
|
thx! |
gsemet
added a commit
that referenced
this pull request
Jan 30, 2017
Quick Open breaks opening URL with port number
gsemet
added a commit
that referenced
this pull request
Jan 30, 2017
Quick Open breaks opening URL with port number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Quick Open is enabled, the regex
^(.*)\:([0-9]+)also matches URLs with a port number (likehttp://127.0.0.1:5000/). guake would then only log an info level message (which is not visible by default) and not try to open the URL as an URL.