Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap terms correctly when moving tabs, fixes #473 and #512 #588

Merged
merged 1 commit into from
Jul 29, 2015

Conversation

mertemba
Copy link
Contributor

#473 and #512 are still present when moving tabs more than one position. Steps to reproduce (same on 0.7.2 and current master):

  • create 3 tabs (a, b, c)
  • move tab c to the left (c, a, b)
  • copy/paste in tabs a and b is interchanged
  • close tab b
  • now tab a is grey as described in Guake Turns Gray sometimes #473

@gsemet gsemet closed this Jul 24, 2015
@gsemet
Copy link
Member

gsemet commented Jul 24, 2015

thankx for this pl!

@pypingou
Copy link
Member

@stibbons I've got to ask, I'm too curious, why do you call pull-request (PR): pl ? :) This has been making me curious for a while now :)

@gsemet
Copy link
Member

gsemet commented Jul 25, 2015

Because it is a Pull Lequest... Just kinding. Indeed now you highlight it I don't understand myself...

(I think I confuse with my bash aliases I used everyday, git pull was "gl")

@pypingou
Copy link
Member

Because it is a Pull Lequest... Just kinding. Indeed now you highlight it I don't understand myself...

Ok, I was just too curious, sorry for asking :D

@mertemba
Copy link
Contributor Author

Good to know what PL stands for :)
Just a question, when will the pull request be merged?
I looked at the other pull requests for 0.8.0 milestone and they are all in master already. I just would like to know when I can switch from my custom build to the latest master branch (using the guake-git AUR package).

@gsemet gsemet reopened this Jul 29, 2015
gsemet added a commit that referenced this pull request Jul 29, 2015
Swap terms correctly when moving tabs, fixes #473 and #512
@gsemet gsemet merged commit b1fc0f7 into Guake:master Jul 29, 2015
@gsemet
Copy link
Member

gsemet commented Jul 29, 2015

I just pushed the wrong button...

@mertemba
Copy link
Contributor Author

Ok, thanks for merging. 👍

gsemet added a commit that referenced this pull request Jan 30, 2017
Swap terms correctly when moving tabs, fixes #473 and #512
gsemet added a commit that referenced this pull request Jan 30, 2017
Swap terms correctly when moving tabs, fixes #473 and #512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants