Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controlling reproducibility of permutations #5

Merged
merged 1 commit into from
Jun 4, 2015

Conversation

vladpetyuk
Copy link
Contributor

No description provided.

@GuangchuangYu
Copy link
Member

This will make the function always reproducible. This is not the right way to put set.seed inside the package. The control should completely be left to the user.

I will accept this pull and add a parameter seed = FALSE, to disable this feature by default. If user wants reproducibility, as in demonstration, set the seed=TRUE explicitly.

GuangchuangYu added a commit that referenced this pull request Jun 4, 2015
controlling reproducibility of permutations
@GuangchuangYu GuangchuangYu merged commit 4bcf3ab into YuLab-SMU:master Jun 4, 2015
@GuangchuangYu
Copy link
Member

see 4d97d3f

GuangchuangYu pushed a commit that referenced this pull request Jun 17, 2015
Commit id: 4bcf3ab

    Merge pull request #5 from vladpetyuk/master

    controlling reproducibility of permutations

Commit id: c37a00f

    controlling reproducibility of permutations



git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/DOSE@104543 bc3139a8-67e5-0310-9ffc-ced21a209358
GuangchuangYu added a commit that referenced this pull request Jul 24, 2017
Commit id: 4bcf3ab

    Merge pull request #5 from vladpetyuk/master

    controlling reproducibility of permutations

Commit id: c37a00f

    controlling reproducibility of permutations



git-svn-id: file:///home/git/hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/DOSE@104543 bc3139a8-67e5-0310-9ffc-ced21a209358
@dnebdal dnebdal mentioned this pull request Aug 20, 2018
GuangchuangYu pushed a commit that referenced this pull request Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants