Fix equals to prevent null values (#388)

Switch frame.getSourceFile().equals(String) around to test String against source file value instead of otherway around to prevent failures when the value is null.
Guardsquare · Feb 21, 2024 · 858bcd0 · 858bcd0
1 parent 1c421bf
commit 858bcd0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/retrace/src/proguard/retrace/FrameRemapper.java b/retrace/src/proguard/retrace/FrameRemapper.java
@@ -116,7 +116,7 @@ private void transformFieldInfo(FrameInfo       obfuscatedFrame,
                     if (fieldInfo.matches(originalType))
                     {
                         originalFieldFrames.add(new FrameInfo(fieldInfo.originalClassName,
-                                                              obfuscatedFrame.getSourceFile().equals("Unknown Source") ?
+                                                              "Unknown Source".equals(obfuscatedFrame.getSourceFile()) ?
                                                                       "Unknown Source" :
                                                                       sourceFileName(fieldInfo.originalClassName),
                                                               obfuscatedFrame.getLineNumber(),
@@ -186,7 +186,7 @@ private void transformMethodInfo(FrameInfo       obfuscatedFrame,
                         }
 
                         originalMethodFrames.add(new FrameInfo(methodInfo.originalClassName,
-                                                               obfuscatedFrame.getSourceFile().equals("Unknown Source") ?
+                                                               "Unknown Source".equals(obfuscatedFrame.getSourceFile()) ?
                                                                        "Unknown Source" :
                                                                        sourceFileName(methodInfo.originalClassName),
                                                                lineNumber,