Skip to content

Commit

Permalink
build: adding to PATH automatically does not work
Browse files Browse the repository at this point in the history
  • Loading branch information
paulmueller committed Nov 17, 2023
1 parent 1c2a3bb commit 7f9c1cb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 61 deletions.
45 changes: 0 additions & 45 deletions build-recipes/win_environment.iss

This file was deleted.

15 changes: 0 additions & 15 deletions build-recipes/win_mpl-data-cast.iss_dummy
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#define MyAppPlatform "win32"
#define MyAppExeName "MPLDataCast.exe"
#define MyAppDir = SourcePath + "dist\MPLDataCast\"
#include "win_environment.iss"

[Setup]
ChangesEnvironment=true
Expand Down Expand Up @@ -45,8 +44,6 @@ Name: "german"; MessagesFile: "compiler:Languages\German.isl"
[Tasks]
Name: "desktopicon"; Description: "{cm:CreateDesktopIcon}"; GroupDescription: "{cm:AdditionalIcons}"; Flags: unchecked

Name: envPath; Description: "Add to PATH variable (required for mpldc.exe CLI)"

[Files]
Source: "{#MyAppDir}{#MyAppExeName}"; DestDir: "{app}"; Flags: ignoreversion
Source: "{#MyAppDir}*"; DestDir: "{app}"; Flags: ignoreversion recursesubdirs createallsubdirs
Expand Down Expand Up @@ -117,16 +114,4 @@ begin
UnInstallOldVersion();
end;
end;
if (CurStep = ssPostInstall) and IsTaskSelected('envPath') then
begin
EnvAddPath(ExpandConstant('{app}') +'\bin');
end;
end;

procedure CurUninstallStepChanged(CurUninstallStep: TUninstallStep);
begin
if CurUninstallStep = usPostUninstall then
begin
EnvRemovePath(ExpandConstant('{app}') +'\bin');
end;
end;
4 changes: 3 additions & 1 deletion docs/sec_intro.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ Installation
For Windows and macOS users, there are installers available at the
`release page <https://github.com/GuckLab/MPL-Data-Cast/releases>`_. The
Windows installer also includes the :ref:`command line interface (CLI) <sec_cli>`
``mpldc.exe``.
``mpldc.exe``. You might want to add the installation directory to your Windows
PATH variable for conveniently using the CLI (see e.g.
`this guide <https://learn.microsoft.com/en-us/previous-versions/office/developer/sharepoint-2010/ee537574(v=office.14)>`_).


If you have Python installed, you can install MPL-Data-Cast with::
Expand Down

0 comments on commit 7f9c1cb

Please sign in to comment.