Rewrite plugin to sort AST #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin now sorts JSON by sorting the AST, instead of using a pre- processor step. This approach is more flexible because we aren't relying on `JSON.parse`, so we can handle invalid JSON. This approach also lets us override the sort order imposed by `JSON.stringify`, specifically that integers always come before string keys.
Gudahtt
force-pushed
the
rewrite-sorting-to-use-ast
branch
from
5b6352c
to
5eeedd5
Compare
This was referenced Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin now sorts JSON by sorting the AST, instead of using a preprocessor step.
This approach is more flexible because we aren't relying on
JSON.parse, so we can handle invalid JSON. This approach also lets us override the sort order imposed byJSON.stringify, specifically that integers always come before string keys.