Fix crash due to engine list not being filtered upon partial results

[vovimayhem]

What does this PR do?

Addresses Issue #8:

• Updated project layout
• Implements the engine filtering with partial results

Closes #8
Closes #9

[vovimayhem]

@thelastinuit Nachito, it's ready. Review it

[mayra-cabrera]

Thoughts on moving former blocks into another method? Just for trying to remove some duplicity.. Something like:

def can_run? (partially_detected_features)
   return true unless @run_rules.present? 
   dependencies_are_met?('engines', partially_detected_features) && dependencies_are_met?('features', partially_detected_features) 
end


def dependencies_engines_are_met? (rule_type, partially_detected_features)
    dependencies = dependencies_for(rule_type)
    features = if rule_type == "engines" 
                   partially_detected_features.map(&:engines).flatten.uniq
                else
                   partially_detected_features.map(&:name).flatten.uniq
                end
    (dependencies & features).sort == dependencies 
end

def dependencies_for rule_type
   @run_rules.fetch(rule_type, []).sort
end

[mayra-cabrera]

Of we can use your original structure:

def can_run? (partially detected_features)
    return true unless @run_rules.present? 
   dependency_engines_are_met?(partially_detected_features) && dependency_features_are_met?(partially_detected_features)
end

def dependency_engines_are_met partially detected_features
     dependency_engines = rules_for('engines')
     engines_ran = partially_detected_features.map(&:engines).flatten.uniq
     dependency_engines_are_met = (dependency_engines & engines_ran).sort == dependency_engines
end

def dependency_features_are_met partially_detected_features
    dependency_features = rules_for('features')
    features_found = partially_detected_features.map(&:name).flatten.uniq
    dependency_features_are_met = (dependency_features & features_found).sort == dependency_features
end

def rules_for type
   @run_rules.fetch(type, []).sort
end

[vovimayhem]

Good point... Let me rinse & repeat this guy

[mayra-cabrera]

@vovimayhem LGTM 🎉

[vovimayhem]

LGTM TOO :D