Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(worker): long running tasks + parallel process lock #102

Merged
merged 46 commits into from
Aug 13, 2021
Merged

refactor(worker): long running tasks + parallel process lock #102

merged 46 commits into from
Aug 13, 2021

Conversation

Guikingone
Copy link
Owner

@Guikingone Guikingone commented May 6, 2021 •
edited

Q A
PHP version? 7.4
Bundle version? 0.6.0
New feature? no
Bug fix? yes

@Guikingone Guikingone added bug Something isn't working PHP Improvement labels May 6, 2021
@Guikingone Guikingone added this to the Current (as patch) milestone May 6, 2021
@Guikingone Guikingone self-assigned this May 6, 2021
@Guikingone Guikingone linked an issue May 6, 2021 that may be closed by this pull request
bug(scheduler): consuming tasks in separate processes #92
Closed
@Guikingone Guikingone changed the title tests(worker): long running tasks refactor(worker): long running tasks + parallel process lock May 8, 2021
@jvancoillie jvancoillie mentioned this pull request May 9, 2021
Closed
@Guikingone Guikingone force-pushed the issue/92 branch 6 times, most recently from d2b44de to c054ebe Compare May 12, 2021 10:59
@Guikingone Guikingone force-pushed the issue/92 branch 2 times, most recently from 792e744 to e75a5ba Compare May 13, 2021 17:22
@jvancoillie
Copy link
Contributor

Hello @Guikingone 👋

Would it be possible to be able to configure the path used on the defualt FlockStore ?
It would be useful to me because I would need to share a directory on K8S between the different cronjobs or I have to use another store maybe ...

@Guikingone
Copy link
Owner Author

Hi @jvancoillie 👋🏻

Yes, I'm gonna check if it can be integrated easily 🙂

@jvancoillie jvancoillie mentioned this pull request Jun 1, 2021
Closed
@Guikingone Guikingone linked an issue Jun 11, 2021 that may be closed by this pull request
(Documentation): filesystem transport default path #124
Closed
@Guikingone Guikingone removed this from the Next (as minor) milestone Jun 11, 2021
@Guikingone
Copy link
Owner Author

Hi @jvancoillie 👋🏻

As the PR seems to fix the issue completely, I'm gonna improve the tests and fix the failing CI steps (except Rector for now), once done, 0.6.0 will be released to publish the fix.

Regarding the issue @chucky2305 is facing, it's planned to be released in 0.6.1 to ease the merge process and the changelog.

@Guikingone Guikingone force-pushed the issue/92 branch 5 times, most recently from 385f2d1 to 6691d1b Compare August 10, 2021 16:54
@Guikingone Guikingone merged commit e54e8a2 into main Aug 13, 2021
@Guikingone Guikingone deleted the issue/92 branch August 13, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvancoillie jvancoillie jvancoillie left review comments

Assignees

@Guikingone Guikingone

Labels
BC breaks bug Something isn't working Improvement PHP scope: scheduler scope: worker
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

bug(scheduler): consuming tasks in separate processes
3 participants
@Guikingone @jvancoillie @chucky2305