fix(bridge): exception thrown during task creation #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babeuloula
force-pushed
the
fix/create-task-error-logic
branch
from
36ac9a3
to
b21d27f
Compare
|
Hi @babeuloula 👋🏻 Thanks for the PR, regarding the BC breaks, the PR introduce none IMHO, the contract defined via the interface already inform that an exception MUST be thrown 🙂 |
Guikingone
reviewed
Jun 21, 2022
Guikingone
reviewed
Jun 21, 2022
Guikingone
approved these changes
Jun 23, 2022
Guikingone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If a task already exists, on Redis we've got an exception but not with Doctrine.
Just fix this logic
/!\ BC break