Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when wait-for-property fails #537

Merged

Conversation

notriddle
Copy link
Contributor

No description provided.

@GuillaumeGomez
Copy link
Owner

Ah right, you need to run npm run api-test -- --bless as well.

@GuillaumeGomez
Copy link
Owner

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit ed5c6c5 into GuillaumeGomez:master Sep 18, 2023
2 checks passed
@notriddle notriddle deleted the notriddle/wait-for-property branch September 18, 2023 19:17
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 18, 2023
…est, r=notriddle

Update browser-ui-test version

It includes the fix from `@notriddle` (GuillaumeGomez/browser-UI-test#537).

r? `@notriddle`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2023
Rollup merge of rust-lang#115949 - GuillaumeGomez:update-browser-ui-test, r=notriddle

Update browser-ui-test version

It includes the fix from `@notriddle` (GuillaumeGomez/browser-UI-test#537).

r? `@notriddle`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants