Shared/Unique FFI unwrap #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split FFI unwrap into owned/shared
|
Can you remove the merge commit please? |
|
Why is the fix readme back? You should try to use the rebase strategy instead of the merge one. Allow to have way better git logs. |
force mutability for rng argument types split FFI unwrap into owned/shared fix compile error fix readme fix compile error
|
yeah i was trying to rebase to remove the 'merge' commit but screwed up, i can make a clean commit and delete this mess, sorry about that! |
|
No problem, thanks a lot for all your work. It's really awesome! |
|
If you don't know how to do it, you can take a look at this blog post. |
|
Yes that's what I was doing but I had to review changes in a lot of files due to the recent pull (the readme one) so it was a bit of a mess. i made a new clean pull request based on the current HEAD so it's fixed anyway, no worries. i'll close this one down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split 'unwrap' method of FFI trait into shared (returns *const _) / owned (returns *mut _) methods, instead of just one method returning *mut _.
This allows applying ownership & mutability rules consistently across all the FFI bindings as long as the C definitions are correct (*const/*mut pointers where appropriate).
Will allow for implementation of unsafe sync/senc traits for certain types (like matrix) or use of smart pointers like Rc/RefCell etc.