Remove cdylib crate-type #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You did a lot of things that are not part of fixing the linked issue and you didn't add explanations for how to do it. |
|
The existing instructions say "look at the Makefile", which is just as true as it was before. There's almost zero use case for pure Rust code doing this since Rust doesn't have a stable ABI. And I wasn't able to test it without fixing the C example, but I can split that to a separate PR if you want. |
|
Please do. 👍 |
jrose-signal
force-pushed
the
remove-cdylib
branch
from
54f7964
to
0fe52ed
Compare
|
Split out to #934! |
Clients who want a cdylib (including C clients) should use `cargo rustc --crate-type cdylib` to override the default crate-type.
jrose-signal
force-pushed
the
remove-cdylib
branch
from
0fe52ed
to
e3fd7d1
Compare
GuillaumeGomez
approved these changes
Feb 14, 2023
|
Thanks! Merging after CI is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients who want a cdylib (including C clients) can use
cargo rustc --crate-type cdylibto override the default crate-type.Fixes #932, see there for more explanation.