-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename public DiskExt method type_
to kind
#966
rename public DiskExt method type_
to kind
#966
Conversation
a cosmetic change, but a breaking one also
src/common.rs
Outdated
/// | ||
/// This type is returned by [`Disk::get_type`][crate::Disk#method.type]. | ||
/// This type is returned by [`crate::DiskExt::kind`]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be displayed as crate::DiskExt::kind
, which isn't great. Can you use the old format please?
I don't mind. Please fix the CI errors and then all good for me. |
The CI seems stuck on the same errors encountered on the other branches, |
Thanks! |
In true esprit d'escalier fashion. It should probably be all renamed to |
That's a good point. Maybe even |
I think "Drive" is (except in the HDD acronym) mostly Windows parlance for a partition mounted on a root letter? I've currently got on Windows several "drives" which are in fact the same device. "Device" seems more generic to me. |
But Device could be pretty much anything, hence why I thought "StorageDevice" would be a better idea. |
That's what I was trying to say, "storage device" seems better here |
Oh sorry. Then yes, we agree. :) |
A cosmetic change, but a breaking one also.
The underscore at the end of
type_
has bothered me for some time now. Maybe using a proximate synonym could be better?