Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sami's Developpement #4

Open
wants to merge 126 commits into
base: Dev
Choose a base branch
from

Conversation

SafarbatiSami
Copy link
Collaborator

No description provided.

SafarbatiSami and others added 30 commits April 18, 2023 12:32
Corrections
Modified Display and Style.
Modified Display of Patch size in the Config Frame.
Modified inputs of patch size , augmentation patch size and number of pool .

Added function to preprocess, autoconfig, save config, print path to config, and update text boxes after run.

Modified button colors and size .
Added remote train and autoconfig.
Added new argument (Remote) to use when on Remote.
Added popup messages.
Redefined dropdown menus.
Added some popup messages.
Added test to create required folders.
Added Parameters return function.
)
parameters_return(patch, pool, batch, config_path)
except:
print("[Error] Import error. Biom3d must be installed if you want to save your configuration. Another solution is to config the function function in biom3d.utils here...")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faute d'orthographe

Copy link
Owner

@GuillaumeMougeot GuillaumeMougeot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Sami,
beau boulot, j'ai ajouté des commentaires, essaie de régler ça avant de merger, refais moi une pull request dès que tu as fait les corrections eventuelles. Envoie moi un message par mail si besoin (mon teams ne marche plus).
Guillaume


if args.remote:
try:
from biom3d.utils import save_python_config
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplica avec lignes 401 à 411. peut être essayer de compresser

@@ -279,15 +291,23 @@ def get_aug_patch(patch_size):

# ----------------------------------------------------------------------------
# Display
def parameters_return(patch, pool, batch, config_path):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a quoi sert cette fonction? documentation


Returns
-------

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indiquer le type de sortie


Returns
-------

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indiquer le type de sortie


Returns
-------

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indiquer le type de sortie

@@ -417,7 +434,10 @@ def __init__(

self.num_channels = 1
self.channel_axis = 0

# Make sur the Channel dim is first ( we assume that the channel dim is the smallest dimension ! )
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faute d'orthographe

@@ -662,6 +685,7 @@ def auto_config_preprocess(
print("Standard deviation of intensities:", std)
print("0.5% percentile of intensities:", perc_005)
print("99.5% percentile of intensities:", perc_995)
print(" Image Type : ",is2d)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retirer l'espace avant Image

@@ -788,6 +817,8 @@ def auto_config_preprocess(
help="(default=False) Whether to print auto-config parameters. Used for remote preprocessing using the GUI.")
parser.add_argument("--debug", default=False, action='store_true', dest='debug',
help="(default=False) Debug mode. Whether to print all image filenames while preprocessing.")
parser.add_argument("--is2d", default=False,
help="(default=False) Check wheter the image has 2d only.")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faute d'orthographe

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

biom3d a déjà un ficher qui se nomme omero_uploader, l'utiliser plutot que celui ci-dessous

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne l'utilise plus, c'est un ancien module que j'avais oublié de supprimer

@@ -309,7 +308,8 @@ def tif_read_imagej(img_path, axes_order='CZYX'):

img = tiff.tifffile.transpose_axes(img, series.axes, axes_order)

img_meta["axes"] = axes_order
#img_meta["axes"] = axes_order
img_meta["axes"] = series.axes
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça marche ça ? c'était ça le bug des dimensions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, c'était pour le bug des Z et T inversés

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants