Fix: Issue 164 - SSH rule creation for bastion host without ELB. #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSH rule creation for bastion host without ELB.
This pull request addresses the issue where SSH access wasn't properly configured for bastion hosts when ELB (Elastic Load Balancer) creation was disabled. The problem occurred due to the conditional logic in the count attribute, which excluded SSH rule creation when create_elb was set to false.
This was a critical issue as it prevented secure access to the bastion host in scenarios where ELB wasn't used.
Changes Made.
Modified the count attribute in the Terraform configuration for bastion host security groups to allow SSH rule creation when one of the following conditions is met:
The bastion_security_group_id is an empty string.
The create_elb is set to false.
Related Issues:
Closes #164