Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for high quality time-based effects to add #4

Closed
GuitarML opened this issue Jun 5, 2021 · 12 comments
Closed

Looking for high quality time-based effects to add #4

GuitarML opened this issue Jun 5, 2021 · 12 comments

Comments

@GuitarML
Copy link
Owner

GuitarML commented Jun 5, 2021

I'm opening this issue as a place to recommend open source time based effects to add to NeuralPi. This includes effects like Reverb, Delay, Chorus, Flange. Ideally these would be high quality effects written in c++ without too many user controls, I'd like to keep it simple. As long as permissions allow, it could be modified to only include the most relevant controls.

The models sound good by themselves, but these effects would add a whole new dimension to NeuralPi's capability. I also know that JUCE has some DSP capability built in, including IR, but have not tested these features yet.

@dromer
Copy link

dromer commented Jun 11, 2021

Surge is making quite a nice collection of effects, many of them time-based, can eye the source here: https://github.com/surge-synthesizer/surge/tree/main/src/common/dsp/effects

@romulka
Copy link

romulka commented Jun 22, 2021

@dromer
Copy link

dromer commented Jun 22, 2021

@romulka how are these repositories relevant in any way?

@GuitarML
Copy link
Owner Author

@romulka Are the plugins in the modep project open source? Either way thanks for the links, I'll be trying that out when I get a chance.

@dromer
Copy link

dromer commented Jun 23, 2021

modep is a derivative of mod-host and everything in the repository is opensource, but realize that you are not pointing to upstream at all.

please take a step back and check what the upstream versions of these plugins are :)

@mishushakov
Copy link

mishushakov commented Jul 14, 2021

related to #2

porting NeuralPi and/or Chameleon to LV2, would enable us to join the MODEP pedalboard, which comes with lots of effects

MODEP also solves the problem of integrating controls, because it already ships with web, android and ios clients

it could especially be interesting hardware-wise, having the pi stomp pedalboard and also the original MOD devices

from marketing perspective, it could give us an opportunity to grow adoption, since blokas and MODEP community are bigger than ours and even pi stomp author claims that "Over 3 dozen pi-Stomp pedals have been built in 8 different countries!"

in personal view, we should stay a "neural pedal" plugin and let the DAW/MODEP manage all the other effects

particularly in Neural Pi's case, Elk OS is a limiting factor, because we'd have to DIY all the desired effects (want a wah-wah pedal? nope, there's no wah-wah in elk) and also implement all the controls!

so, instead of bringing the effects to us, why not bring us to the effects? 😃

@GuitarML
Copy link
Owner Author

@mishushakov I like that idea a lot, and it shouldn't be to hard to build lv2 with the current cmake implementation. Ill start going down that route. Thanks!

@mishushakov
Copy link

mishushakov commented Jul 15, 2021

great, thanks for letting everyone know!
moreover, i believe openness and flexibility is what allowed the project to become what it is

i only touched the surface of what mod is capable of, but speaking for myself, i'd rather prefer my Raspberry Pi to be a full pedalboard instead of a pedal with effects 😃

@dromer
Copy link

dromer commented Jul 15, 2021

Yup, I'm also playing a lot with MOD and the modular synth environment makes a lot of sense for me (it's how I use jack/pipewire and "pro audio" on linux). I also play a lot with physical hardware, so the integration feels very natural.

Having a couple basic/suitable effects internally is no shame though!
But I wouldn't go overkill and turn NeuralPI into more than what it needs to be.

@jfsantos
Copy link

jfsantos commented Aug 4, 2021

Really interested in seeing this work ported to LV2! Do you have a public WIP repo to share at this point?

@GuitarML
Copy link
Owner Author

GuitarML commented Aug 5, 2021

@jfsantos yes, the current main branch supports lv2 building with cmake, also reference this closed issue for build instructions:

#2

@GuitarML
Copy link
Owner Author

Added IR, reverb, and delay using the juce::dsp module in release 1.2, closing this issue as the original intent has been resolved. We can continue LV2/MODEP conversation in a new discussion thread. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants