Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LV2 builds? #2

Closed
dromer opened this issue Jun 1, 2021 · 8 comments · Fixed by #7
Closed

LV2 builds? #2

dromer opened this issue Jun 1, 2021 · 8 comments · Fixed by #7

Comments

@dromer
Copy link

dromer commented Jun 1, 2021

As you may know jatinchowdhury18 uses a JUCE fork to enable LV2 builds for their plugins.

Will you consider doing the same? this would make your plugins available to a wider audience.

@GuitarML
Copy link
Owner

GuitarML commented Jun 1, 2021

That's probably a good idea, I'll add it to the to-do list. In the meantime if anyone wants to do their own LV2 build I'd recommend following this guide (also by jatinchowdhury18):
Building LV2 Plugins with JUCE and CMake

@dromer
Copy link
Author

dromer commented Jul 15, 2021

Btw I'm not sure how this host config for setting the samplerate will work, I don't think this is very typical for plugin hosts to set it like this.

[edit: oh wait, this is ELK configuration. I assume that the plugin works at other samplerates? (48k at least)]

@GuitarML
Copy link
Owner

@dromer It works, but the sound gets distorted. Since the ML models learn from audio at a certain samplerate (44.1kHz in this case), that's the samplerate that reproduces the most accurate sound. Ideally we would implement an internal samplerate converter, which is what NeuralDSP does in their plugins, reference

@mishushakov
Copy link

mishushakov commented Jul 19, 2021

my LV2 port report

Screenshot 2021-07-19 at 21 53 13

i assume something went wrong with git submodules
LV2 was CMakeLists.txt under FORMATS, but JUCE ignored that

what i did:

remove modules/DISTRHO-JUCE submodule, else it's not going to compile

- [submodule "modules/DISTRHO-JUCE"]
- 	path = modules/DISTRHO-JUCE
- 	url = https://github.com/Chowdhury-DSP/DISTRHO-JUCE.git

and from modules/CMakeLists.txt

- if(UNIX AND NOT APPLE)
-    add_subdirectory(DISTRHO-JUCE)
- else()
-    add_subdirectory(JUCE)
- endif()
+ add_subdirectory(JUCE)

replace JUCE distro submodule in .gitmodules with lv2 port

[submodule "modules/JUCE"]
	path = modules/JUCE
-       url = https://github.com/juce-framework/JUCE.git
+       url = https://github.com/lv2-porting-project/JUCE
+       branch = lv2

@jatinchowdhury18
Copy link
Contributor

I was able to get LV2 builds working on this branch. Strange, it seems like I used the exact same approach as @mishushakov. Anyway, if you want to try it out:

$ git checkout lv2
$ git submodule sync
$ git submodule update --init --recursive
$ cmake -Bbuild
$ cmake --build NeuralPi_LV2 --parallel

@mishushakov
Copy link

mishushakov commented Jul 21, 2021

success!

Screenshot 2021-07-21 at 23 59 42

notice the CPU usage at the bottom (261%)
it stutters when i press "play" in reaper
maybe that's because i'm on a vm?

...and we should should probably mention in the docs, which dependencies are required to build, so you don't have to guess:

apt install cmake build-essential juce-tools

here's the .lv2 for anyone to try (built on latest Ubuntu, amd64): NeuralPi.lv2.zip

@GuitarML
Copy link
Owner

Great work all, thanks!

@mishushakov
Copy link

the usage was probably that high, because i didn't build in Release mode

GuitarML pushed a commit that referenced this issue Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants