various cpp improvement in src folder #538
Merged
+23
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…terruptedException
What changes were proposed in this pull request?
Before a Kafka consumer gets assigned with partitions, its offset will contain 0 partitions. However, runContinuous will still run and launch a Spark job having 0 partitions. In this case, there is a race that epoch may interrupt the query execution thread after
lastExecution.toRdd
, and eitherepochEndpoint.askSync[Unit](StopContinuousExecutionWrites)
or the nextrunContinuous
will get interrupted unintentionally.To handle this case, this PR has the following changes:
queryExecutionThread.runUninterruptibly
. This may increase the waiting time ofstop
but should be minor because the operations here are very fast (just sending an RPC message in the same process and stopping a very simple thread).runContinuous
call. We may clear the interrupted status set bystop
, but it doesn't affect the query termination becauserunActivatedStream
will checkstate
and exit accordingly.I also updated the clean up codes to make sure exceptions thrown from
epochEndpoint.askSync[Unit](StopContinuousExecutionWrites)
won't stop the clean up.How was this patch tested?
Jenkins
Closes apache#24034 from zsxwing/SPARK-27111.
Authored-by: Shixiong Zhu zsxwing@gmail.com
Signed-off-by: Shixiong Zhu zsxwing@gmail.com
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.