Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shared queries to reusable functions #441

Open
AudunVN opened this issue May 21, 2021 · 1 comment
Open

Move shared queries to reusable functions #441

AudunVN opened this issue May 21, 2021 · 1 comment

Comments

@AudunVN
Copy link
Member

AudunVN commented May 21, 2021

We have a lot of code that want the same data (e.g., a specific set of invoices or cruises), but a lot of these use completely separate model query instances. This makes code very hard to maintain, as there is no easy way to find out which queries you should update where if the definition of an object class changes (such as "unfinished invoices").

@AudunVN
Copy link
Member Author

AudunVN commented May 21, 2021

See also 2b8b54f, where I found out that we have five queries that should be identical for the "invoices that need admin attention" case with no obvious way to find and update them when things change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant