Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to publish to local Maven repo #12

Merged

Conversation

bannmann
Copy link
Contributor

This PR allows developers to publish RR to their local Maven repository directory.

In another (locally built) project, one can then declare a dependency Maven/Gradle dependency on de.bottlecaps.rr:rr-lib:1.63.

Note: my end goal is to create an RR Maven plugin. For this I will need additional (mostly harmless) changes, but I'd like to submit separate PRs for those.

@bannmann
Copy link
Contributor Author

Let me know if you prefer de.bottlecaps.railroad as the group ID (or just edit the PR accordingly). I don't care either way. Usually I'd go with the root Java package name, but the "official product name" seems to be more "RR" than "Railroad".

Copy link
Owner

@GuntherRademacher GuntherRademacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection.

In my test configuration (Java 15, Gradle 7.2, Buildship 3.1.5) I had to explicitly exclude xml-apis, like this:

testImplementation ('de.bottlecaps.rr:rr-lib:1.63') { exclude module: 'xml-apis' }

in order to avoid complaints about duplicate packages javax.xml.parsers and others, which are present in xml-apis as well as in the JRE.

@GuntherRademacher GuntherRademacher merged commit eb852df into GuntherRademacher:master Oct 29, 2021
@bannmann bannmann deleted the local-maven-publish branch October 29, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants