Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line Optimization in Public Transport #132

Merged
merged 18 commits into from
Mar 19, 2024
Merged

Line Optimization in Public Transport #132

merged 18 commits into from
Mar 19, 2024

Conversation

Marika-K
Copy link
Member

@Marika-K Marika-K commented Jan 15, 2024

Description

A new optimod for line optimization in public transport.

There is currently no issue for this optimod but it is related to Network Design Optimod #36

Checklist

  • Implementation:
    • Implementation of the Mod in the gurobi_optimods installable package
    • Tests for the Mod implementation in tests/
    • Docstrings for public API, correctly linked using sphinx-autodoc
  • Documentation page:
    • Background and problem specification
    • Example of the input data format (use gurobi_optimods.datasets for loading data)
    • Runnable code example
    • Presentation of solutions
    • Included in the mod gallery and toctree

Have a nice day!

@Marika-K Marika-K marked this pull request as draft January 15, 2024 09:22
@simonbowly
Copy link
Member

This looks awesome, thanks for the great work @Marika-K! The multi-objective component is a particularly nice feature.

@stevedwards in applications terms I think this quite different from the network design mod, and it would make sense to have both of them in the library separately. Thoughts?

@stevedwards
Copy link

Yeah, this is super, super nice. Love everything about it. The level of abstraction is perfect for an optimod. Yeah @simonbowly totally makes sense to have them separately. Great work @Marika-K

@Marika-K
Copy link
Member Author

Thanks! I am happy that this Optimod fits.
Do you know what the problem with test_portfolio.py could be?

@simonbowly
Copy link
Member

Looks like a numerics problem, happens from time to time with that mod. It looks like all your tests are passing so nothing to worry about. Just mark this PR "ready for review" when ready!

@Marika-K Marika-K marked this pull request as ready for review January 22, 2024 15:42
Copy link
Member

@simonbowly simonbowly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Marika-K thanks for the great work, and sorry for the delay. I added a couple of comments.

I also did a little polishing of the introduction text, could you check that my changes look ok there?

docs/source/mods/line-optimization.rst Show resolved Hide resolved
src/gurobi_optimods/line_optimization.py Outdated Show resolved Hide resolved
src/gurobi_optimods/line_optimization.py Outdated Show resolved Hide resolved
Copy link
Member

@simonbowly simonbowly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few more comments. After these, I think it's good to go!

src/gurobi_optimods/line_optimization.py Outdated Show resolved Hide resolved
docs/source/mods/line-optimization.rst Outdated Show resolved Hide resolved
docs/source/mods/line-optimization.rst Show resolved Hide resolved
src/gurobi_optimods/line_optimization.py Outdated Show resolved Hide resolved
@Marika-K
Copy link
Member Author

Thanks, Simon!
I updated the code and added some more exception handling. If you do not see any issues, I think I am done.

@simonbowly
Copy link
Member

Looks good, thanks!

@simonbowly simonbowly merged commit 23b019b into Gurobi:main Mar 19, 2024
10 checks passed
@simonbowly
Copy link
Member

And again, great work @Marika-K! This is a really nice addition :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants