Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortest path #48

Merged
merged 6 commits into from
May 15, 2023
Merged

Shortest path #48

merged 6 commits into from
May 15, 2023

Conversation

torressa
Copy link
Member

@torressa torressa commented May 2, 2023 •
edited
Loading

Description

Implements shortest path problem from #11

Checklist

  • Implementation:
    • Implementation of the Mod in the gurobi_optimods installable package
    • Tests for the Mod implementation in tests/
    • Docstrings for public API, correctly linked using sphinx-autodoc
  • Documentation page:
    • Problem specification with description tab and optimisation model tab
    • Example of the input data format (use gurobi_optimods.datasets for loading data)
    • Runnable code example
    • Presentation of solutions

Have a nice day!

@torressa torressa self-assigned this May 2, 2023
@torressa torressa marked this pull request as ready for review May 4, 2023 12:56
@torressa torressa requested a review from simonbowly May 4, 2023 12:56
@torressa
Copy link
Member Author

torressa commented May 4, 2023

Reasonably happy with this; used the same overload stuff from your matching mod.

simonbowly
simonbowly approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@simonbowly simonbowly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Will merge this as is for now but we should do a pass together through the various graphy mods to make sure it's all fairly consistent.

simonbowly
simonbowly approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@simonbowly simonbowly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Will merge this as is for now but we should do a pass together through the various graphy mods to make sure it's all fairly consistent.

simonbowly
simonbowly approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@simonbowly simonbowly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Will merge this as is for now but we should do a pass together through the various graphy mods to make sure it's all fairly consistent.

@simonbowly simonbowly merged commit ddcdc19 into Gurobi:main May 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbowly simonbowly simonbowly approved these changes

Assignees

@torressa torressa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@torressa @simonbowly