Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add author support in rss feed item #34

Closed
krishansubudhi opened this issue Jan 11, 2021 · 4 comments · Fixed by #36
Closed

Please add author support in rss feed item #34

krishansubudhi opened this issue Jan 11, 2021 · 4 comments · Fixed by #36
Assignees
Labels
enhancement New feature or request

Comments

@krishansubudhi
Copy link

I saw the source code and figured out author support is not available. We want the blog authors name in the feed items.
Can you add that please?

@Guts Guts self-assigned this Jan 11, 2021
@Guts Guts added the enhancement New feature or request label Jan 11, 2021
@Guts Guts added this to the 1.0.0 milestone Jan 11, 2021
@Guts
Copy link
Owner

Guts commented Jan 11, 2021

Thanks for your interest @krishansubudhi !

Could you further document your idea?

Should we use git contributor or page.meta.author?

How should the final tag be formatted?

It would really help to implement it quickly :)

@krishansubudhi
Copy link
Author

We can add the feature through page.meta.author.
git contributor is also a good feature but page.meta.author should override git contributor.
The formatting should be like this

  <author>
  <name>Krishan Subudhi</name>
  </author>

@krishansubudhi krishansubudhi removed their assignment Jan 15, 2021
@Guts
Copy link
Owner

Guts commented Jan 18, 2021

Thanks for your inputs.

We can add the feature through page.meta.author.

I think we should take into an account that a page can have multiple authors, like co-contributors in git.

git contributor is also a good feature but page.meta.author should override git contributor.

The plugin was first thought to use git information. Nevertheless, we can move forward more easily with the metadata of the page. Let's start by this side, then I'll see the git logic from @timvink plugins.

The formatting should be like this

 <author>
 <name>Krishan Subudhi</name>
  </author>

Refering to the RSS standard to ensure our compliance. the author tag should have an email address:

It'll be natural with the git log, but for the page.meta it's on the page writer.

@krishansubudhi
Copy link
Author

krishansubudhi commented Jan 19, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants